-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
crypto: fix subtle.getPublicKey error for secret type key inputs #59558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
panva
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
panva:fix-getPublicKey-order
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59558 +/- ##
==========================================
+ Coverage 89.74% 89.86% +0.11%
==========================================
Files 667 667
Lines 195301 195321 +20
Branches 38261 38341 +80
==========================================
+ Hits 175280 175517 +237
+ Misses 12465 12257 -208
+ Partials 7556 7547 -9
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Aug 20, 2025
c49bbb9
to
450b16f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
confirmed-bug
Issues with confirmed bugs.
crypto
Issues and PRs related to the crypto subsystem.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
experimental
Issues and PRs related to experimental features.
needs-ci
PRs that need a full CI run.
webcrypto
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://wicg.github.io/webcrypto-modern-algos/#SubtleCrypto-method-getPublicKey
Any secret-type key input should give
NotSupportedError
.Public-type key input should give
InvalidAccessError
.