sea: allow using inspector command line flags with SEA #59568
Merged
+193
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
joyeecheung
force-pushed
the
sea-inspect
branch
from
1371698 to
9626cef
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59568 +/- ##
==========================================
- Coverage 89.84% 89.84% -0.01%
==========================================
Files 667 667
Lines 196260 196259 -1
Branches 38563 38566 +3
==========================================
- Hits 176332 176327 -5
+ Misses 12382 12377 -5
- Partials 7546 7555 +9
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Aug 23, 2025
jasnell
approved these changes
Aug 23, 2025
RaisinTen
approved these changes
Aug 24, 2025
github-actions
bot
removed
the
request-ci
joyeecheung
force-pushed
the
sea-inspect
branch
from
9626cef to
de57287
Compare
|
Removed |
The inspector command line flags should be allowed via NODE_OPTIONS, though it should not be consumed when passed directly to the SEA. This patch allows it to consume inspector flags from NODE_OPTIONS and add tests for different behaviors.
joyeecheung
force-pushed
the
sea-inspect
branch
from
de57287 to
efb8376
Compare
|
Rebased and added skip entries to sync up with #59563 |
aymen94
approved these changes
Aug 27, 2025
|
CI is green. This needs a re-approval to land. @jasnell @addaleax @RaisinTen can you take another look please? Thanks! |
RaisinTen
approved these changes
Aug 27, 2025
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in bcb802c |
targos
pushed a commit
that referenced
this pull request
Aug 28, 2025
The inspector command line flags should be allowed via NODE_OPTIONS, though it should not be consumed when passed directly to the SEA. This patch allows it to consume inspector flags from NODE_OPTIONS and add tests for different behaviors. PR-URL: #59568 Fixes: #51688 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inspector command line flags should be allowed via NODE_OPTIONS, though it should not be consumed when passed directly to the SEA. This patch allows it to consume inspector flags from NODE_OPTIONS and add tests for different behaviors.
Combined with #59560, users can still disable inspector options in NODE_OPTIONS if they set
execArgvExtensionto eithernoneorcli. They could alos enable it via the special CLI flag--node-options="--inspect"if they set it tocliin the configuration.Fixes: #51688