Skip to content

tools: don't fetch V8 deps in the source tree #60883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tools: don't fetch V8 deps in the source tree #60883

wants to merge 1 commit into from
+8 −0

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Nov 28, 2025 •
edited
Loading

The Node.js source tree already includes several V8 DEPS under deps/v8/third_party that are needed to build Node.js. Exclude these in tools/v8/fetch_deps.py to prevent "Conflicting directory" warnings when running the V8 CI.

e.g. https://ci.nodejs.org/job/node-test-commit-v8-linux/6886/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/consoleFull

10:35:32 Warnings:
10:35:32 Conflicting directory ./v8/third_party/jinja2 moved to ./_bad_scm/v8/third_party/jinja2ev06og_3.
10:35:32 Conflicting directory ./v8/third_party/fp16/src moved to ./_bad_scm/v8/third_party/fp16/srcofo97bgs.
10:35:32 Conflicting directory ./v8/third_party/fast_float/src moved to ./_bad_scm/v8/third_party/fast_float/src9v1zqv71.
10:35:32 Conflicting directory ./v8/third_party/abseil-cpp moved to ./_bad_scm/v8/third_party/abseil-cppki9can6x.
10:35:32 Conflicting directory ./v8/third_party/markupsafe moved to ./_bad_scm/v8/third_party/markupsafechfk151u.
10:35:32 Conflicting directory ./v8/third_party/googletest/src moved to ./_bad_scm/v8/third_party/googletest/srcnct99h20.
10:35:32 Conflicting directory ./v8/third_party/simdutf moved to ./_bad_scm/v8/third_party/simdutfu_7og22d.
10:35:32 Conflicting directory ./v8/third_party/zlib moved to ./_bad_scm/v8/third_party/zlib7aw3bhfj.
10:35:32 Conflicting directory ./v8/third_party/dragonbox/src moved to ./_bad_scm/v8/third_party/dragonbox/src_awrr_e7.
10:35:32 Conflicting directory ./v8/third_party/highway/src moved to ./_bad_scm/v8/third_party/highway/srcfch45l4t.
10:35:32 git update is recommended.

I initially added all of the above to the overrides in tools/v8/fetch_deps.py but the V8 CI failed when some of them were skipped which suggests the V8 build requires things that have been removed from/not copied into the Node.js source tree:

  • v8/third_party/googletest/src
iojs@test-hetzner-ubuntu2204-x64-2:~/build/workspace/node-test-commit-v8-linux/deps/v8$ PATH=/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/depot_tools:/home/iojs/build/workspace/node-test-commit-v8-linux/depot_tools:/home/iojs/venv/bin:/home/iojs/nghttp2/src:/home/iojs/wrk:/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin tools/dev/v8gen.py -vv x64.release
################################################################################
/usr/bin/python3 -u tools/mb/mb.py gen -f infra/mb/mb_config.pyl -m developer_default -b x64.release out.gn/x64.release

  Writing """\
  dcheck_always_on = false
  is_debug = false
  target_cpu = "x64"
  """ to /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/x64.release/args.gn.

  /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/buildtools/linux64/gn gen out.gn/x64.release --check
    -> returned 1
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/include/gmock/gmock-cardinalities.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/include/gmock/gmock-actions.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/include/gmock/gmock-matchers.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/include/gmock/gmock-function-mocker.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/include/gmock/gmock-more-matchers.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/include/gmock/gmock-more-actions.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/include/gmock/gmock-spec-builders.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/include/gmock/internal/gmock-port.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/include/gmock/internal/gmock-internal-utils.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/include/gmock/gmock-nice-strict.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/include/gmock/gmock.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/src/gmock-cardinalities.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/src/gmock-internal-utils.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/src/gmock.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock_main
  has a source file:
    //third_party/googletest/src/googlemock/src/gmock_main.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/include/gmock/internal/gmock-pp.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/src/gmock-matchers.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/gtest-assertion-result.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gmock
  has a source file:
    //third_party/googletest/src/googlemock/src/gmock-spec-builders.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/gtest-death-test.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/gtest-matchers.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/gtest-param-test.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/gtest-printers.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/gtest-test-part.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/gtest-message.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/gtest-typed-test.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/gtest-spi.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/gtest.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/internal/gtest-filepath.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/internal/gtest-param-util.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/internal/gtest-port.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/internal/gtest-string.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/src/gtest-death-test.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/internal/gtest-death-test-internal.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/include/gtest/internal/gtest-type-util.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/src/gtest-port.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/src/gtest-matchers.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/src/gtest-printers.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/src/gtest-typed-test.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/src/gtest-internal-inl.h
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/src/gtest-test-part.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/src/gtest-assertion-result.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/src/gtest.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest_main
  has a source file:
    //third_party/googletest/src/googletest/src/gtest_main.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
      target(_target_type, target_name) {
      ^----------------------------------
  The target:
    //third_party/googletest:gtest
  has a source file:
    //third_party/googletest/src/googletest/src/gtest-filepath.cc
  which was not found.
  ___________________
  ERROR at //build/config/BUILDCONFIG.gn:648:5: Source file not found.
      target(_target_type, _target_name) {
      ^-----------------------------------
  The target:
    //third_party/zlib:zlib_bench
  has a source file:
    //third_party/zlib/contrib/bench/zlib_bench.cc
  which was not found.
  GN gen failed: 1
Traceback (most recent call last):
  File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/dev/v8gen.py", line 256, in <module>
    sys.exit(gen.main())
  File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/dev/v8gen.py", line 250, in main
    return self._options.func()
  File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/dev/v8gen.py", line 147, in cmd_gen
    self._call_cmd([
  File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/dev/v8gen.py", line 189, in _call_cmd
    output = subprocess.check_output(
  File "/usr/lib/python3.10/subprocess.py", line 421, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.10/subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/python3', '-u', 'tools/mb/mb.py', 'gen', '-f', 'infra/mb/mb_config.pyl', '-m', 'developer_default', '-b', 'x64.release', 'out.gn/x64.release']' returned non-zero exit status 1.
iojs@test-hetzner-ubuntu2204-x64-2:~/build/workspace/node-test-commit-v8-linux/deps/v8$
  • v8/third_party/zlib
iojs@test-hetzner-ubuntu2204-x64-1:~/build/workspace/node-test-commit-v8-linux/deps/v8$ PATH=/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/depot_tools:/home/iojs/build/workspace/node-test-commit-v8-linux/depot_tools:/home/iojs/venv/bin:/home/iojs/nghttp2/src:/home/iojs/wrk:/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin tools/dev/v8gen.py -vv x64.release
################################################################################
/usr/bin/python3 -u tools/mb/mb.py gen -f infra/mb/mb_config.pyl -m developer_default -b x64.release out.gn/x64.release

  Writing """\
  dcheck_always_on = false
  is_debug = false
  target_cpu = "x64"
  """ to /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/x64.release/args.gn.

  /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/buildtools/linux64/gn gen out.gn/x64.release --check
    -> returned 1
  ERROR at //build/config/BUILDCONFIG.gn:648:5: Source file not found.
      target(_target_type, _target_name) {
      ^-----------------------------------
  The target:
    //third_party/zlib:zlib_bench
  has a source file:
    //third_party/zlib/contrib/bench/zlib_bench.cc
  which was not found.
  GN gen failed: 1
Traceback (most recent call last):
  File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/dev/v8gen.py", line 256, in <module>
    sys.exit(gen.main())
  File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/dev/v8gen.py", line 250, in main
    return self._options.func()
  File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/dev/v8gen.py", line 147, in cmd_gen
    self._call_cmd([
  File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/dev/v8gen.py", line 189, in _call_cmd
    output = subprocess.check_output(
  File "/usr/lib/python3.10/subprocess.py", line 421, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.10/subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/python3', '-u', 'tools/mb/mb.py', 'gen', '-f', 'infra/mb/mb_config.pyl', '-m', 'developer_default', '-b', 'x64.release', 'out.gn/x64.release']' returned non-zero exit status 1.
iojs@test-hetzner-ubuntu2204-x64-1:~/build/workspace/node-test-commit-v8-linux/deps/v8$

so I have left the above two out of this PR (i.e. we'll still get warnings for those).

cc @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 28, 2025
@richardlau
tools: don't fetch V8 deps in the source tree
e25a6ce 
The Node.js source tree already includes several V8 DEPS under
`deps/v8/third_party` that are needed to build Node.js. Exclude these
in `tools/v8/fetch_deps.py` to prevent "Conflicting directory" warnings
when running the V8 CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richardlau @lpinca @cjihrig @nodejs-github-bot