Skip to content

fix(blog): apply proper route to metadata call #8224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(blog): apply proper route to metadata call #8224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/site/app/[locale]/blog/[...path]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const generateViewport = basePage.generateViewport;

// This generates each page's HTML Metadata
// @see https://nextjs.org/docs/app/api-reference/functions/generate-metadata
export const generateMetadata = basePage.generateMetadata;
export const generateMetadata = basePage.generateBlogMetadata;

// Generates all possible static paths based on the locales and environment configuration
// - Returns an empty array if static export is disabled (`ENABLE_STATIC_EXPORT` is false)
Expand Down
16 changes: 16 additions & 0 deletions apps/site/next.dynamic.page.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { sep } from 'node:path';

import { notFound, redirect } from 'next/navigation';
import { setRequestLocale } from 'next-intl/server';

Expand Down Expand Up @@ -34,6 +36,20 @@ export const generateMetadata = async props => {
return dynamicRouter.getPageMetadata(locale, pathname);
};

/**
* This generates each blog's HTML Metadata
*
* @see https://nextjs.org/docs/app/api-reference/functions/generate-metadata
*
* @param {{ params: Promise<{ path: Array<string>; locale: string }> }} props
* @returns {Promise<import('next').Metadata>} the metadata for the page
*/
export const generateBlogMetadata = async props => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, can we make an overload of generateMetadata that supports path prefixes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/**
 * This generates each page's HTML Metadata
 *
 * @see https://nextjs.org/docs/app/api-reference/functions/generate-metadata
 *
 * @param {{ params: Promise<{ path: Array<string>; locale: string; prefix?: string }> }} props
 * @returns {Promise<import('next').Metadata>} the metadata for the page
 */
export const generateMetadata = async props => {
  const { path = [], prefix = '', locale = defaultLocale.code } = await props.params;

  const pathname = dynamicRouter.getPathname(path);

  return dynamicRouter.getPageMetadata(locale, `${prefix}${pathname}`);
};

Copy link
Member

@ovflowd ovflowd Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then usage:

// This generates each page's HTML Metadata
// @see https://nextjs.org/docs/app/api-reference/functions/generate-metadata
export const generateMetadata = props => basePage.generateMetadata({ ...props, prefix: 'blog' });

const { path = [], locale = defaultLocale.code } = await props.params;
const pathname = dynamicRouter.getPathname(path);
return dynamicRouter.getPageMetadata(locale, `blog${sep}${pathname}`);
};

/**
* This method is used for retrieving the current locale and pathname from the request
*
Expand Down
Loading