Skip to content

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Oct 15, 2025

We need to build the blog data before deploying

Signed-off-by: Aviv Keller <[email protected]>
Copy link

vercel bot commented Oct 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 15, 2025 2:23pm

@avivkeller avivkeller changed the title fix(OpenNext): only deploy fix(OpenNext): build blog data Oct 15, 2025
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.44%. Comparing base (0740938) to head (ec22e4f).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8228   +/-   ##
=======================================
  Coverage   76.44%   76.44%           
=======================================
  Files         115      115           
  Lines        9643     9643           
  Branches      316      316           
=======================================
  Hits         7372     7372           
  Misses       2270     2270           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller marked this pull request as ready for review October 15, 2025 14:23
@avivkeller avivkeller requested a review from a team as a code owner October 15, 2025 14:23
@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 14:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a pre-build step to generate blog data before deploying the OpenNext Cloudflare worker so the site has up-to-date content at deploy time.

  • Introduces a "Build blog data" step in the site workflow.
  • Runs the blog data build in the apps/site directory prior to the OpenNext worker build.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MattIPv4
Copy link
Member

Can we dispatch the workflow against this branch to confirm this fix works?

@dario-piotrowicz
Copy link
Member

I am not sure why this is necessary, wasn't the blog building done in a postinstall script?

@dario-piotrowicz
Copy link
Member

dario-piotrowicz commented Oct 15, 2025

I am not sure why this is necessary, wasn't the blog building done in a postinstall script?

Ah yeah there are pre* scripts that should be triggering that 🤔

"prebuild": "node --run build:blog-data",

@MattIPv4
Copy link
Member

MattIPv4 commented Oct 15, 2025

node --run does not run pre/post hooks, that is the one major difference vs. what npm run et al do

@avivkeller
Copy link
Member Author

Can we dispatch the workflow against this branch to confirm this fix works?

I did when I opened the PR, apologies for not linking the run, https://github.com/nodejs/nodejs.org/actions/runs/18532159595

@avivkeller
Copy link
Member Author

avivkeller commented Oct 15, 2025

node --run does not run pre/post hooks, that is the one major difference vs. what npm run et al do

Even if it did, those lifecycle scripts wouldn't apply to the worker variants, right?

@dario-piotrowicz
Copy link
Member

node --run does not run pre/post hooks, that is the one major difference vs. what npm run et al do

ah ok, thanks for the extra context 🙂

@dario-piotrowicz
Copy link
Member

node --run does not run pre/post hooks, that is the one major difference vs. what npm run et al do

Even if it did, those lifecycle scripts wouldn't apply to the worker variants, right?

oh yeah you're right 😕

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@avivkeller
Copy link
Member Author

@nodejs/web-infra feel free to merge once approved, I'm requesting fast track

@avivkeller avivkeller added the fast-track Fast Tracking PRs label Oct 16, 2025
@MattIPv4 MattIPv4 added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit cb6c9bc Oct 16, 2025
17 checks passed
@MattIPv4 MattIPv4 deleted the Fix-OpenNext branch October 16, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants