Skip to content

chore(gov): remove web-standards #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

avivkeller
Copy link
Member

Closes #10.

Before merging this, the following steps are required:

  • @nodejs/web-standards removed as a child of @nodejs/web
  • @nodejs/web's description be set to "Responsible for the development and maintenance of Node.js's Web Presence", or similar.

@avivkeller avivkeller requested a review from a team as a code owner July 13, 2025 23:48
@avivkeller
Copy link
Member Author

CC @nodejs/TSC

@ovflowd
Copy link
Member

ovflowd commented Jul 13, 2025

The issue didn't even pass and you're opening a PR already? 🫠

@avivkeller
Copy link
Member Author

avivkeller commented Jul 13, 2025

The issue received 5 approvals and no objections after 72 hours, which I believe qualifies as a pass.

I believe this aligns with the typical process for administrative changes as outlined in the nodejs/admin repo

@ovflowd
Copy link
Member

ovflowd commented Jul 13, 2025

I'd consider it passing once it gets closed no?

@avivkeller
Copy link
Member Author

No? I would assume that the issue gets closed when the action gets taken to resolve it.

i.e. a Node.js Core Collaborator nomination issue is closed by the PR to add the nominee, not when the nomination passes.

@avivkeller
Copy link
Member Author

Bump @nodejs/TSC

@ljharb

This comment was marked as outdated.

@ovflowd
Copy link
Member

ovflowd commented Jul 26, 2025

We need a tsc-agenda to add this to the TSC agenda. To clarify for @nodejs/tsc we want the web-standards team to be removed from the @nodejs/web group and just be added diredctly to the same level all other "technical teams" for pining @ nodejs/node are.

@avivkeller

This comment was marked as resolved.

@joyeecheung
Copy link
Member

we want the web-standards team to be removed from the @nodejs/web group and just be added diredctly to the same level all other "technical teams" for pining @ nodejs/node are.

SGTM (or that was what I thought how it worked in the first place).

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avivkeller
Copy link
Member Author

Hey TSC! A lot of yall have approved this, but we still need you to remove the team as a child, as defined in the PR description, can you please do that?

Once it's done, feel free to remove the agenda and blocked label.

@joyeecheung
Copy link
Member

Looks like nobody objects after a month. Going to push the button.

@joyeecheung
Copy link
Member

I moved @nodejs/web-standards under @nodejs/all-members and updated the description of @nodejs/web.

@joyeecheung joyeecheung reopened this Aug 18, 2025
@joyeecheung
Copy link
Member

Oops, this should be merged, not closed. Not sure if simply pushing the merge button here would suffice. @avivkeller feel free the push the button.

@avivkeller avivkeller added this pull request to the merge queue Aug 18, 2025
Merged via the queue into main with commit 74cbb48 Aug 18, 2025
7 checks passed
@avivkeller avivkeller deleted the avivkeller/chore/remove-web-standards branch August 18, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove @nodejs/web-standards from @nodejs/web