Filter with closures #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Could you please use |
Callers can add timestamp support as a field during log message formatting.
Owner
|
The idea feels great. I will test the performance impact before merging. |
|
Since this breaks API compatibility, I might recommend adding a method in addition to |
Author
|
I merged in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for building ftlog! I've customized it a little bit with this PR. It allows 2 types of closures (filters) to be added. The first type will drop logs before they're ever added into the pipeline. Could be useful for really spammy log entries. The second type allows setting a closure to select the Appender to use. This allows the user to use any criteria they want to redirect logs. The background for this change is I have a desire to redirect log entries based on a key/value pair that's in the log message. So instead of just filtering on the level I want to filter on the message itself.
I also added in some cargo clippy fixes and some little cleanup things.