Skip to content

performance - read only pool POC #9197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

performance - read only pool POC #9197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/util/postgres_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,10 +626,10 @@ class PostgresTable {
}


get_pool() {
const pool = this.client.get_pool(this.pool_key);
get_pool(key = this.pool_key) {
const pool = this.client.get_pool(key);
if (!pool) {
throw new Error(`The postgres clients pool ${this.pool_key} disconnected`);
throw new Error(`The postgres clients pool ${key} disconnected`);
}
return pool;
}
Expand Down Expand Up @@ -1494,6 +1494,10 @@ class PostgresClient extends EventEmitter {
md: {
instance: null,
size: config.POSTGRES_MD_MAX_CLIENTS
},
read_only: {
instance: null,
size: config.POSTGRES_DEFAULT_MAX_CLIENTS
}
};

Expand All @@ -1507,6 +1511,8 @@ class PostgresClient extends EventEmitter {
} else {
// get the connection configuration. first from env, then from file, then default
const host = process.env.POSTGRES_HOST || fs_utils.try_read_file_sync(process.env.POSTGRES_HOST_PATH) || '127.0.0.1';
//optional read-only host. if not present defaults to general pg host
const host_ro = process.env.POSTGRES_HOST_RO || fs_utils.try_read_file_sync(process.env.POSTGRES_HOST_RO_PATH) || host;
const user = process.env.POSTGRES_USER || fs_utils.try_read_file_sync(process.env.POSTGRES_USER_PATH) || 'postgres';
const password = process.env.POSTGRES_PASSWORD || fs_utils.try_read_file_sync(process.env.POSTGRES_PASSWORD_PATH) || 'noobaa';
const database = process.env.POSTGRES_DBNAME || fs_utils.try_read_file_sync(process.env.POSTGRES_DBNAME_PATH) || 'nbcore';
Expand All @@ -1520,6 +1526,7 @@ class PostgresClient extends EventEmitter {
port,
...params,
};
this.pools.read_only.host = host_ro;
}
// As we now also support external DB we don't want to print secret user data
// so this code will mask out passwords from the printed pool params
Expand Down Expand Up @@ -1718,8 +1725,12 @@ class PostgresClient extends EventEmitter {
if (!pool) {
throw new Error(`create_pool: the pool ${name} is not defined in pools object`);
}
const new_pool_params = _.clone(this.new_pool_params);
if (pool.host) {
new_pool_params.host = pool.host;
}
if (!pool.instance) {
pool.instance = new Pool({ ...this.new_pool_params, max: pool.size });
pool.instance = new Pool({ ...new_pool_params, max: pool.size });
if (!pool._error_listener) {
pool.error_listener = err => {
dbg.error(`got error on postgres pool ${name}`, err);
Expand Down