Skip to content

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Jun 22, 2024

This fixes the test failure described in #693 by wrapping the global Context in std::mem::ManuallyDrop to prevent the compiler from dropping it at the beginning of the second test when overwriting it. putting each test into its own file so they each get a fresh Context.

It also adds a missing reference to the doctest of the animation module to fix it and removes the failing doctest of text::Font::set_filter.

Fixes #693.

@cyrgani cyrgani changed the title Fix most of the broken tests Fix all of the broken tests Jul 11, 2024
@cyrgani cyrgani deleted the branch not-fl3:master July 12, 2024 09:28
@cyrgani cyrgani closed this Jul 12, 2024
@cyrgani cyrgani deleted the master branch July 12, 2024 09:28
@cyrgani cyrgani restored the master branch July 12, 2024 09:34
@cyrgani cyrgani reopened this Jul 12, 2024
@cyrgani cyrgani marked this pull request as draft July 12, 2024 09:51
@cyrgani
Copy link
Contributor Author

cyrgani commented Jul 12, 2024

Marking this as a draft as it cannot fix the new error described in #693 (comment).

@cyrgani cyrgani marked this pull request as ready for review July 28, 2024 21:41
@cyrgani
Copy link
Contributor Author

cyrgani commented Jul 28, 2024

By putting each test function into its own file, they do not reuse any old statics and therefore they succeed.
This should be ready to merge now @not-fl3.

@cyrgani
Copy link
Contributor Author

cyrgani commented Dec 18, 2024

Closing in favor of #866.

@cyrgani cyrgani closed this Dec 18, 2024
@cyrgani cyrgani deleted the master branch December 18, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coroutine_pause.rs test broken on head

1 participant