add http-stream support, URL is hardcoded for now #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reordering and grouping them. also clean up markup by removing autoplay="false" which is not correct html5 Signed-off-by: Christian Krafft <[email protected]>
|
This should either be an option on the command line or in the browser |
|
I tested this with Chrome, it appears that the local volume slider doesn't work. |
Contributor
|
For my updated version that tries to derive the stream url, stores it in a cookie and makes it configurable see: https://github.com/SuperBFG7/ympd/tree/local_play |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi notandy,
the stream url is still hardcoded to some http://mpd:8000/mpd.ogg
dont know whether mpd can provide this info
on the other hand:
maybe better to make the stream URL configurable on the client side:
if mpd also streams to a broadcaster, one wants to check whether the stream is "on air" too.