-
Notifications
You must be signed in to change notification settings - Fork 110
Content for inbound webhooks page #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for docs-novu failed. Why did it fail? →
|
WalkthroughAdds a Developer docs section for Webhooks: a new inbound webhooks page, an updated outbound webhooks icon, and JSON metadata files to surface the Developer and Webhooks entries in the docs navigation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
public/images/developer-tools/enable-inbound.png
is excluded by!**/*.png
public/images/developer-tools/inbound-enabled.png
is excluded by!**/*.png
📒 Files selected for processing (5)
content/docs/platform/developer/meta.json
(1 hunks)content/docs/platform/developer/webhooks/inbound-webhooks.mdx
(1 hunks)content/docs/platform/developer/webhooks/meta.json
(1 hunks)content/docs/platform/developer/webhooks/outbound-webhooks.mdx
(1 hunks)content/docs/platform/meta.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Redirect rules - docs-novu
- GitHub Check: Header rules - docs-novu
- GitHub Check: Pages changed - docs-novu
- GitHub Check: Build and Lint
🔇 Additional comments (4)
content/docs/platform/developer/webhooks/outbound-webhooks.mdx (1)
5-5
: Icon choice looks good.Line 5: Swapping to the
Upload
icon makes sense for outbound-specific visuals and stays consistent with the new Webhooks subsection.content/docs/platform/meta.json (1)
48-49
: Navigation entry plugs in cleanly.Lines 48-49: Adding the
---Developer---
divider and...developer
pointer follows the existing metadata convention, so the new section should surface as expected.content/docs/platform/developer/meta.json (1)
1-3
: Parent metadata is wired correctly.Lines 1-3: The Developer meta file now delegates to the Webhooks subsection, aligning with the new navigation entry.
content/docs/platform/developer/webhooks/meta.json (1)
1-6
: Webhooks subsection metadata looks solid.Lines 1-6: Title/icon/page configuration matches the rest of the docs structure, so both inbound and outbound pages should show up under Developer → Webhooks with the right iconography.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary by CodeRabbit