Skip to content

Fix install-strategy=linked package name for workspace packages + workaround for another bug #8096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: latest
Choose a base branch
from
Draft

Fix install-strategy=linked package name for workspace packages + workaround for another bug #8096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b01eca
Fix install-strategy=linked package name for workspace packages
xkr47 Feb 11, 2025
d8f033c
fix: For some reason `this.idealTree.children.get` is not always defined
xkr47 Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workspaces/arborist/lib/arborist/isolated-reifier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ module.exports = cls => class IsolatedReifier extends cls {
]
result.root = this.rootNode
result.id = this.counter++
result.name = node.name
result.name = node.packageName || node.name
result.package = { ...node.package }
result.package.bundleDependencies = undefined
result.hasInstallScript = node.hasInstallScript
Expand Down
2 changes: 1 addition & 1 deletion workspaces/arborist/lib/arborist/reify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ module.exports = cls => class Reifier extends cls {
if (includeWorkspaces) {
// add all ws nodes to filterNodes
for (const ws of this.options.workspaces) {
const ideal = this.idealTree.children.get(ws)
const ideal = this.idealTree.children.get && this.idealTree.children.get(ws)
if (ideal) {
filterNodes.push(ideal)
}
Expand Down