[nrf noup] boot: zephyr: Delay bm IO button check #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
force-pushed
the
bmdelay
branch
2 times, most recently
from
c52793b to
a4d0238
Compare
de-nordic
reviewed
Aug 20, 2025
| @@ -93,6 +93,9 @@ bool io_detect_pin(void) | |||
|
|
|||
| nrf_gpio_cfg_input(BOARD_PIN_BTN_0, BM_BUTTONS_PIN_PULLUP); | |||
|
|
|||
| /* Delay 5 us for pull-up to be applied */ | |||
| k_busy_wait(5); | |||
There was a problem hiding this comment.
5 not 10? Commit states 10us.
nrf-squash! [nrf noup] boot: zephyr: Add bm firmware loader code Delays checking IO button state by 5us after pull-up has been applied to allow time for it to be applied Signed-off-by: Jamie McCrae <[email protected]>
|
michalek-no
approved these changes
Aug 21, 2025
maciejpietras
approved these changes
Aug 21, 2025
vidarbe
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nrf-squash! [nrf noup] boot: zephyr: Add bm firmware loader code
Delays checking IO button state by 5us after pull-up has been applied to allow time for it to be applied