[nrf noup] nRF54h20: support for S2RAM resume for DIRECT-XIP mode #545
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchy
approved these changes
Sep 30, 2025
tomchy
reviewed
Sep 30, 2025
| (DT_REG_ADDR(DT_GPARENT(DT_NODELABEL(node_label)))))) | ||
|
|
||
| #define S2RAM_SLOT_INFO_A 0x37 | ||
| #define S2RAM_SLOT_INFO_B 0xA4 |
There was a problem hiding this comment.
In theory, you have a full 32-bit field here, so you may go crazy with those magic numbers 🙂
There was a problem hiding this comment.
yeah, rest 24 b are reserve for somethin...
There was a problem hiding this comment.
non-init RAM is garbage when the device is powered on, so the chance that one of these values just happens to be in the RAM location that is checked is 1 in 128? I don't like those odds, and there is no CRC or anything to confirm it's even valid from the image itself Have checked rest of code and can see it is properly protected, 1 byte for this is sufficient
de-nordic
approved these changes
Sep 30, 2025
Added direct-xip support: * new API for marking active slot to be used by boot_go() routines. * jump vector assignment which is basing on above designation. Signed-off-by: Andrzej Puzdrowski <[email protected]>
Added call which designate active slot so MCUBoot can jump to proper slot when CPU is resuming from S2RAM. Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
feature/NCSDK-35392
branch
from
cf62803 to
5d5f1ec
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added direct-xip support to pm_s2ram nRF54h bootloader's resume implementation:
Dragged in above feature into boot_go() using API provided.
manifest-pr-skip