-
Notifications
You must be signed in to change notification settings - Fork 1.4k
applications/samples: Don't use minimal libc for MCUboot in CHIP #24468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 3ffe87981e873a9394d20911a556e95252141be2 more detailssdk-nrf:
Github labels
List of changed files detected by CI (29)
Outputs:ToolchainVersion: 2b2cd9579a Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR here. |
Integration is failing. The nRF54LM20 does not boot - seems it is this issue: |
@nordicjm do you plan to add release note in this PR on another one? |
It will be added to migration notes in future yes |
Please create jira ticket to make sure that the relevant documentation will be added. |
983f613
to
1dc599a
Compare
@@ -1,26 +1,3 @@ | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove all things from here and there? We can just add the proposed note regarding KRKNWK-20774 and set CONFIG_MINIMAL_LIBC=y
, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was a mistake, want meant to append from a temp. file I had in sdk-mcuboot but replaced rather than appended, fixed
CONFIG_SPI_NOR=y | ||
CONFIG_SPI_NOR_SFDP_DEVICETREE=y | ||
CONFIG_SPI_NOR_FLASH_LAYOUT_PAGE_SIZE=4096 | ||
CONFIG_PM_OVERRIDE_EXTERNAL_DRIVER_CHECK=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option cannot be removed without fixing Kconfig.sysbuild first, as you mentioned here: #24233 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Goes to piclibc, except for nrf54lm20dk which has an issue. Also fixes a wrong selection of a Kconfig which should be done at sysbuild level Signed-off-by: Jamie McCrae <[email protected]>
1dc599a
to
3ffe879
Compare
Goes to piclibc
NCSDK-35362