Skip to content

Conversation

nordicjm
Copy link
Contributor

Goes to piclibc

NCSDK-35362

@nordicjm nordicjm requested a review from a team as a code owner September 10, 2025 12:49
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 10, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 10, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 3ffe87981e873a9394d20911a556e95252141be2

more details

sdk-nrf:

PR head: 3ffe87981e873a9394d20911a556e95252141be2
merge base: ab8bfe6d03fdb11c2daae3d926aa8fd17ecc7954
target head (main): bbed9cca38a06d1161e2c37f3d164efcad2389ff
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (29)
applications
│  ├── matter_bridge
│  │  ├── sysbuild
│  │  │  ├── mcuboot
│  │  │  │  │ prj.conf
samples
│  ├── matter
│  │  ├── contact_sensor
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp.conf
│  │  ├── light_bulb
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp.conf
│  │  │  │  │  │ prj.conf
│  │  ├── light_switch
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp.conf
│  │  │  │  │  │ prj.conf
│  │  ├── lock
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp.conf
│  │  │  │  │  │ prj.conf
│  │  ├── manufacturer_specific
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp.conf
│  │  │  │  │  │ prj.conf
│  │  ├── smoke_co_alarm
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp.conf
│  │  │  │  │  │ prj.conf
│  │  ├── temperature_sensor
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp.conf
│  │  │  │  │  │ prj.conf
│  │  ├── template
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp.conf
│  │  │  │  │  │ prj.conf
│  │  ├── thermostat
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp.conf
│  │  │  │  │  │ prj.conf
│  │  ├── window_covering
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp.conf
│  │  │  │  │  │ prj.conf

Outputs:

Toolchain

Version: 2b2cd9579a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:2b2cd9579a_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 102
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-chip
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link

You can find the documentation preview for this PR here.

@doublemis1
Copy link
Contributor

Integration is failing. The nRF54LM20 does not boot - seems it is this issue:
https://nordicsemi.atlassian.net/browse/KRKNWK-20774

@doublemis1
Copy link
Contributor

@nordicjm do you plan to add release note in this PR on another one?
Or any other form of documentation that the recommended lib due to security aspect is picolib in the mcuboot.
This is part of ticket's AC.

@nordicjm
Copy link
Contributor Author

@nordicjm do you plan to add release note in this PR on another one? Or any other form of documentation that the recommended lib due to security aspect is picolib in the mcuboot. This is part of ticket's AC.

It will be added to migration notes in future yes

@kkasperczyk-no
Copy link
Contributor

@nordicjm do you plan to add release note in this PR on another one? Or any other form of documentation that the recommended lib due to security aspect is picolib in the mcuboot. This is part of ticket's AC.

It will be added to migration notes in future yes

Please create jira ticket to make sure that the relevant documentation will be added.

@nordicjm nordicjm force-pushed the nominimallibcmcubootmatter branch from 983f613 to 1dc599a Compare September 16, 2025 09:47
@@ -1,26 +1,3 @@
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove all things from here and there? We can just add the proposed note regarding KRKNWK-20774 and set CONFIG_MINIMAL_LIBC=y, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a mistake, want meant to append from a temp. file I had in sdk-mcuboot but replaced rather than appended, fixed

CONFIG_SPI_NOR=y
CONFIG_SPI_NOR_SFDP_DEVICETREE=y
CONFIG_SPI_NOR_FLASH_LAYOUT_PAGE_SIZE=4096
CONFIG_PM_OVERRIDE_EXTERNAL_DRIVER_CHECK=y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option cannot be removed without fixing Kconfig.sysbuild first, as you mentioned here: #24233 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Goes to piclibc, except for nrf54lm20dk which has an issue. Also
fixes a wrong selection of a Kconfig which should be done at
sysbuild level

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm nordicjm force-pushed the nominimallibcmcubootmatter branch from 1dc599a to 3ffe879 Compare September 16, 2025 11:01
@nordicjm nordicjm requested a review from a team as a code owner September 16, 2025 11:01
@nordicjm nordicjm merged commit d81382b into nrfconnect:main Sep 17, 2025
14 checks passed
@nordicjm nordicjm deleted the nominimallibcmcubootmatter branch September 23, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants