Explicit casts to get around gcc14 warnings treated as errors. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p+wheels default parameters
|
Thanks for the PR. I had a look at the changed code and it seems like these variables should simply not be referenced since they are local arrays and already treated as pointers for strncpy. I fixed this (and other GCC warnings) in PR #70 which I'll look to get merged and a release out soon. PyPredict version with the fix will be 1.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are from with pip+wheels default parameters. This allows for pip install to work on machines where gcc14 is default gcc without having to change links or aliases. Keyword restrict has been supported since c99 so should be safe to use.