Skip to content

fix(gitlab_provider): update member retrieval method to include all members #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix(gitlab_provider): update member retrieval method to include all members #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a02134
fix(gitlab_provider): update member retrieval method to include all m…
Sep 20, 2024
431eaed
refactor: Update gitlab2sentry/utils/gitlab_provider.py
Lujeni Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gitlab2sentry/utils/gitlab_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ def _get_default_mentions(self, project: Project) -> str:
return ", ".join(
[
f"@{member.username}"
for member in project.members.list()
for member in project.members_all.list(iterator=True)
if (
member.access_level >= GITLAB_MENTIONS_ACCESS_LEVEL
and member.state != "blocked"
Expand Down
4 changes: 2 additions & 2 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ def __init__(self, username, access_level, state):

class TestGitlabProject:
def __init__(self):
self.members = TestGitlabMemberManager()
self.members_all = TestGitlabMemberManager()


class TestGitlabMemberManager:
def list(self):
def list(self, *args, **kwargs):
return TEST_GITLAB_PROJECT_MEMBERS


Expand Down
2 changes: 1 addition & 1 deletion tests/test_gitlab_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def test_get_default_mentions(gitlab_provider_fixture, gitlab_project_fixture):
)
_project_non_blocked_members = [
member
for member in gitlab_project_fixture.members.list()
for member in gitlab_project_fixture.members_all.list()
if member.state != "blocked"
]
assert len(_mentioned_members) == len(_project_non_blocked_members)
Expand Down
Loading