Skip to content

refactor: use pydandic settings to handle configuration #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

refactor: use pydandic settings to handle configuration #23

merged 1 commit into from
Oct 8, 2024

Conversation

Lujeni
Copy link
Member

@Lujeni Lujeni commented Sep 30, 2024

see #21

@Lujeni Lujeni force-pushed the issue_21 branch 2 times, most recently from 84c35f3 to 438fae9 Compare September 30, 2024 19:54
ultrabug
ultrabug approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@ultrabug ultrabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have more consistently sorted variables/properties in alphabetical order but that's just a cosmetic point of view

@Lujeni
Copy link
Member Author

Lujeni commented Oct 8, 2024

I would have more consistently sorted variables/properties in alphabetical order but that's just a cosmetic point of view

done :)

@Lujeni Lujeni merged commit 5cfca24 into master Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ultrabug ultrabug ultrabug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lujeni @ultrabug