Skip to content

Update csharpier: 0.30.6 -> 1.0.2 #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thomaslaich
Copy link
Contributor

@thomaslaich thomaslaich commented Jun 15, 2025

Update csharpier to support breaking changes in v1.0.0

The csharpier tool introduced breaking changes in its 1.0.0 release:

  • The executable name changed from dotnet-csharpier to csharpier.
  • The CLI usage changed: formatting now requires the subcommand format, i.e.,
    csharpier format <file> instead of dotnet-csharpier <file>.

This PR updates the csharpier program definition in treefmt-nix to use the new CLI interface.

EDIT: I also added myself as the maintainer if that's ok.

@thomaslaich thomaslaich marked this pull request as ready for review June 15, 2025 10:39
@thomaslaich
Copy link
Contributor Author

Apparently, the nix-build was not successful.

I had to update the flake nixpkgs input to have access to the new csharpier version. This somehow seems to break deno, even though locally I cannot reproduce this (on both aarch64-darwin and x86_64-linux i can format files with deno-fmt without problems).

Not sure how I can fix this. Anyone can shed some light on these errors?

@jfly
Copy link
Contributor

jfly commented Jun 24, 2025

I also cannot repro the issue locally. Feels like a flaky build. @brianmcgee is it possible to re-trigger the build and see if it succeeds on a second try?

@zimbatm zimbatm enabled auto-merge (squash) July 9, 2025 10:08
@zimbatm zimbatm force-pushed the update/csharpier branch from a9fc27f to c4e4172 Compare July 9, 2025 10:08
@thomaslaich
Copy link
Contributor Author

@zimbatm
There still seems to be one check failing. Can I somehow assist in fixing it?

@zimbatm
Copy link
Member

zimbatm commented Jul 20, 2025

Yes, can you dig into the errors and see where they are coming from?

CI works well on the other branches, so I'm not sure what the root cause is

@lafrenierejm
Copy link

There still seems to be one check failing. Can I somehow assist in fixing it?

Yes, can you dig into the errors and see where they are coming from?

CI works well on the other branches, so I'm not sure what the root cause is

This is the error I'm seeing for the aarch64-darwin failure on https://buildbot.numtide.com/#/builders/16/builds/383:

cachix: ConnectionError (HttpExceptionRequest Request {
  host                 = "cachix.org"
  port                 = 443
  secure               = True
  requestHeaders       = [("Accept","application/json;charset=utf-8,application/json"),("Authorization","<REDACTED>"),("User-Agent","cachix 1.7.9")]
  path                 = "/api/v1/cache/numtide"
  queryString          = ""
  method               = "GET"
  proxy                = Nothing
  rawBody              = False
  redirectCount        = 10
  responseTimeout      = ResponseTimeoutDefault
  requestVersion       = HTTP/1.1
  proxySecureMode      = ProxySecureWithConnect
}
 (InternalException (HandshakeFailed (Error_Misc "Network.Socket.recvBuf: does not exist (No route to host)"))))

To me, this looks like a network failure that is most likely completely unrelated to any changes in this PR. If a rebuild can be triggered, I suspect it would be successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants