Skip to content

fix: biome config extension missing #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

andrea11
Copy link
Contributor

@andrea11 andrea11 commented Jul 29, 2025

Sorry, with the PR #391, I introduced an issue with biome v2+. The biome CLI refuses configuration if they do not have .json extension.

@zimbatm zimbatm enabled auto-merge (squash) July 29, 2025 12:30
auto-merge was automatically disabled July 29, 2025 20:16

Head branch was pushed to by a user without write access

@andrea11
Copy link
Contributor Author

Hi @zimbatm, I forgot to update the example. Can you re-approve?

@khaneliman
Copy link
Contributor

khaneliman commented Jul 30, 2025

Just was coming looking for what caused issue i see after a flake update and this looks like it'd fix it.

nix fmt
ERRO formatter | biome: failed to apply with options '[check --write --no-errors-on-unmatched --config-path /nix/store/sw7wdx5cdqrzdd7vdk7f6p9pf61ilm9d-validated-biome-config]': exit status 1

/nix/store/sw7wdx5cdqrzdd7vdk7f6p9pf61ilm9d-validated-biome-config configuration ━━━━━━━━━━━━━━━━━━━

  × Invalid configuration file. Expected JSON or JSONC file, but got /nix/store/sw7wdx5cdqrzdd7vdk7f6p9pf61ilm9d-validated-biome-config.

@priegger
Copy link

priegger commented Aug 1, 2025

I can confirm that this PR fixes the currently broken biome support in main.

Pinning the flake to the commit hash from this branch works for me:

inputs.treefmt-nix.url = "github:numtide/treefmt-nix?rev=d669b561b678d23c40332142573685b0d08225d0";

Pinning the flake to a commit hash before #391 works for me:

inputs.treefmt-nix.url = "github:numtide/treefmt-nix?rev=2673921c03d6e75fdf4aa93e025772608d1482cf";

Using the current main branch does not work for me.

@zimbatm zimbatm merged commit 58bd4da into numtide:main Aug 1, 2025
3 checks passed
@andrea11 andrea11 deleted the fix/biome-config branch August 1, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants