Skip to content

Fixes PHP TypeError when asserting for a non-visible field #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mediabounds wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Fixes PHP TypeError when asserting for a non-visible field #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/DrupalExtension/Context/VisibilityContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,13 @@ public function iShouldNotSeeTheField($field) {
*
* @param string $element
* Element selector or a string that describes it.
* @param \Behat\Mink\Element\NodeElement $node
* @param \Behat\Mink\Element\NodeElement|null $node
* Node representing the element above, if any.
*
* @throws \Behat\Mink\Exception\ExpectationException
* Throws exception if element not found.
*/
protected function assertElementVisible($element, NodeElement $node) {
protected function assertElementVisible($element, ?NodeElement $node) {
try {
if ($node && !$node->isVisible()) {
throw new ExpectationException(sprintf("The element '%s' is not present on the page %s", $element, $this->getSession()->getCurrentUrl()), $this->getSession());
Expand All @@ -96,13 +96,13 @@ protected function assertElementVisible($element, NodeElement $node) {
*
* @param string $element
* Element selector or a string that describes it.
* @param \Behat\Mink\Element\NodeElement $node
* @param \Behat\Mink\Element\NodeElement|null $node
* Node representing the element above, if any.
*
* @throws \Behat\Mink\Exception\ExpectationException
* Throws exception if element is found.
*/
protected function assertElementNotVisible($element, NodeElement $node) {
protected function assertElementNotVisible($element, ?NodeElement $node) {
try {
if ($node && $node->isVisible()) {
throw new ExpectationException(sprintf("The field '%s' was present on the page %s and was not supposed to be", $element, $this->getSession()->getCurrentUrl()), $this->getSession());
Expand Down