Skip to content

feat(leaflet): update compatibility version to >=4.0.0 #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025

Conversation

Gugustinette
Copy link
Contributor

πŸ”— Linked issue

nuxt-modules/leaflet#265

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Apparently, when using nuxi to install a module, nuxi will override the compatibility version exported by the module itself using the compatibility version in the yml config here.
That caused nuxi to wrongly report the leaflet module as incompatible in this case.

This kind of PR will probably happen for every module migrating to Nuxt v4 I guess ?

@Gugustinette
Copy link
Contributor Author

@danielroe done πŸ‘

So the problem came from my usage of ^3.0.0 instead of >=3.0.0 ?

@danielroe
Copy link
Member

yes, ^3.0.0 constrains it to only work on v3, not on v2 or v4. >= is probably the safest approach going forward - we can always narrow it down if it's not compatible with a future version

@Gugustinette
Copy link
Contributor Author

Ok I wasn't aware of that difference, It's quite possible other modules have made the same mistake then πŸ‘€

@atinux atinux merged commit 13490af into nuxt:main Jul 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants