feat(runtime): allow registerEndpoint to work with native fetch
#1415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
yamachi4416
force-pushed
the
native-fetch-endpoint-mock
branch
2 times, most recently
from
06b41d4 to
5225e00
Compare
|
The tests pass with happy-dom, but with jsdom the tests fail because Request is not supported. How should I handle this... |
yamachi4416
force-pushed
the
native-fetch-endpoint-mock
branch
2 times, most recently
from
a4f0c91 to
6fd1b45
Compare
yamachi4416
changed the title
registerEndpoint to work with native fetchregisterEndpoint to work with native fetch
|
Thank you for letting me use this all the time. I think it’s now ready for your review. Sorry if my first pull request is a bit clumsy. I’d appreciate it if you could review it. |
yamachi4416
force-pushed
the
native-fetch-endpoint-mock
branch
from
6fd1b45 to
7466d77
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #1261
It might work if you specify fetch in the adapter.
❓ Type of change
📚 Description
I tried to make
registerEndpointsupport mocking native fetch.