Skip to content

feat(Toolbar): new component #4382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

MrKaashee
Copy link

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I've added a new <Toolbar> component.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@MrKaashee MrKaashee requested a review from benjamincanac as a code owner June 22, 2025 11:14
Copy link

pkg-pr-new bot commented Jun 22, 2025

npm i https://pkg.pr.new/@nuxt/ui@4382

commit: 7456c37

@ineshbose
Copy link
Member

Is this similar to DashboardToolbar?

@MrKaashee
Copy link
Author

Is this similar to DashboardToolbar?

It’s similar in purpose but more general. Toolbar is reusable beyond dashboards and includes more functionality like variant support and a title prop. I also plan to extend it further in future updates.

@ineshbose
Copy link
Member

Yes I figure the layout is the same, and to be honest I noticed that the DashboardToolbar isn't specific to Dashboard components within a DashboardGroup as it doesn't inject any of the dashboard context (I am using it in my own app outside of Dashboard), therefore I also feel its generic and good to introduce to non-pro * imo *

@MrKaashee
Copy link
Author

Agreed β€” makes sense. This version aims to be more flexible and generic .

Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not take advantage of Reka UI's Toolbar component? πŸ€”
https://reka-ui.com/docs/components/toolbar

@MrKaashee MrKaashee force-pushed the feat/toolbar-component branch from 3c8468e to 7456c37 Compare July 3, 2025 06:51
@MrKaashee
Copy link
Author

Thanks @benjamincanac! I considered Reka’s Toolbar, but since Nuxt UI already uses a custom one in DashboardToolbar, I followed the same approach.

Reka UI’s Toolbar is quite structured, but I wanted something more flexible.

This version is something I’ve already been using in my projects, so I decided to bring it into Nuxt UI with improvements like slots, variants, and better reusability.

Introduces a new 'size' prop and size variants (sm, md, lg, xl) to the Toolbar component, updates theme definitions, playground usage, and tests to support and demonstrate the new sizing options.
Copy link
Member

benjamincanac commented Jul 3, 2025

The DashboardToolbar from Nuxt UI Pro is a layout component that is meant to be used under a DashboardNavbar to build a dashboard, basically it's just a div with flex items-center justify-between and some slots. It is different from a functional Toolbar component like https://reka-ui.com/docs/components/toolbar

I guess we can close this if you don't plan to implement it on top of Reka UI? Also, I'd like to implement the Toggle/ToggleGroup components before this one: https://reka-ui.com/docs/components/toggle-group

@kashiarain
Copy link

Thanks for the clarification!

No need to close this PR β€” I will implement the Toolbar on top of Reka UI.
Will update this PR once ready!

@benjamincanac benjamincanac marked this pull request as draft July 3, 2025 14:18
@MrKaashee MrKaashee closed this by deleting the head repository Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants