-
Notifications
You must be signed in to change notification settings - Fork 824
feat(Toolbar): new component #4382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
Is this similar to DashboardToolbar? |
Itβs similar in purpose but more general. Toolbar is reusable beyond dashboards and includes more functionality like variant support and a title prop. I also plan to extend it further in future updates. |
Yes I figure the layout is the same, and to be honest I noticed that the DashboardToolbar isn't specific to Dashboard components within a DashboardGroup as it doesn't inject any of the dashboard context (I am using it in my own app outside of Dashboard), therefore I also feel its generic and good to introduce to non-pro * imo * |
Agreed β makes sense. This version aims to be more flexible and generic . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not take advantage of Reka UI's Toolbar component? π€
https://reka-ui.com/docs/components/toolbar
3c8468e
to
7456c37
Compare
Thanks @benjamincanac! I considered Rekaβs Toolbar, but since Nuxt UI already uses a custom one in Reka UIβs Toolbar is quite structured, but I wanted something more flexible. This version is something Iβve already been using in my projects, so I decided to bring it into Nuxt UI with improvements like slots, variants, and better reusability. |
Introduces a new 'size' prop and size variants (sm, md, lg, xl) to the Toolbar component, updates theme definitions, playground usage, and tests to support and demonstrate the new sizing options.
The I guess we can close this if you don't plan to implement it on top of Reka UI? Also, I'd like to implement the Toggle/ToggleGroup components before this one: https://reka-ui.com/docs/components/toggle-group |
Thanks for the clarification! No need to close this PR β I will implement the Toolbar on top of Reka UI. |
π Linked issue
β Type of change
π Description
I've added a new
<Toolbar>
component.π Checklist