Skip to content

Conversation

@benjamincanac
Copy link
Member

@benjamincanac benjamincanac commented Nov 22, 2025

πŸ”— Linked issue

Resolves #5045, related to #4242

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 22, 2025

npm i https://pkg.pr.new/@nuxt/ui@5511

commit: c101f0c

@benjamincanac benjamincanac requested a review from romhml November 26, 2025 16:47
</UButton>

<template #footer="{ close }">
<UFieldGroup clear>
Copy link
Member

@romhml romhml Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look intuitive since this FieldGroup's purpose is to cancel the previous one and not be one. We should do that automatically on all components with nested content that could be used in a FieldGroup.

We could make a new component to wrap the Modal, Slideover, Popover contents which voids the Button Group injection internally:

<NestedContent> <!-- provide(fieldGroupInjectionKey, null) -->
  <slot name="content"> ... </slot>
</NestedContent>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it might be better that manually having to wrap buttons every time. Could we just call useFieldGroup() in those components? πŸ€”

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a separate component, the trick is that the trigger should inherit from the FieldGroup injection, while the content shouldn't

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you can't just override the injection in the modal component for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<ClearFieldGroup>

3 participants