APPLE: variuos fixes #3646
Merged
APPLE: variuos fixes #3646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokas-ambrazevicius
force-pushed
the
rap/fixes
branch
from
9c679ba to
52e03c3
Compare
rokas-ambrazevicius
force-pushed
the
rap/fixes
branch
from
144f50c to
bc84588
Compare
pronebird
requested changes
Oct 9, 2025
There was a problem hiding this comment.
@pronebird reviewed 2 of 19 files at r1.
Reviewable status: 2 of 19 files reviewed, 1 unresolved discussion (waiting on @trojanfoe)
nym-vpn-apple/ServicesMacOS/Sources/GRPCManager/GRPCManager.swift line 102 at r1 (raw file):
switch event { case let .newState(tunnelState): Task { @MainActor in
This method already runs on main queue
pronebird
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
@pronebird reviewed 17 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rokas-ambrazevicius and @trojanfoe)
rokas-ambrazevicius
added a commit
that referenced
this pull request
Oct 9, 2025
* Add region search * APPLE: update launch animation * APPLE: update country expanding logic * APPLE: bump build * APPLE: integrate core changes (#3649) * APPLE: add QUIC reconnect alert * macOS: fix daemon not restarting
trojanfoe
reviewed
Oct 9, 2025
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
JIRA-VPN-XXXX
Description
Add region search
Update launch animation
Update country expanding logic in the dropdown
Checklist:
Screenshots (optional, if UI related)
This change is