chore: moved nym-gateway-probe to the monorepo #3648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pronebird
reviewed
Oct 9, 2025
There was a problem hiding this comment.
Why do we need to move nym-connection-monitor and nym-common to nym repo?
Reviewable status: 0 of 30 files reviewed, all discussions resolved
pronebird
requested changes
Oct 15, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 30 files reviewed, 2 unresolved discussions
nym-vpn-core/Cargo.toml line 5 at r2 (raw file):
members = [ "crates/nym-apple-network", "crates/nym-common",
Probably need to revert this too
nym-vpn-core/Cargo.toml line 6 at r2 (raw file):
"crates/nym-apple-network", "crates/nym-common", "crates/nym-connection-monitor",
and this
pronebird
reviewed
Oct 15, 2025
There was a problem hiding this comment.
@pronebird reviewed 16 of 30 files at r1, 14 of 14 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jstuczyn)
jstuczyn
force-pushed
the
feature/gateway-probe-migration
branch
from
c4cd65d to
0a337a0
Compare
pronebird
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
N/A
Description
this PR moves
nym-gateway-probe(alongsideto the monorepo.nym-commonandnym-connection-monitor)Checklist:
Screenshots (optional, if UI related)
This change is