Vpn-4403: JWT skew cache tests

[agentpietrucha]

Ticket

JIRA-VPN-4403

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Checklist:

• Changelog

Screenshots (optional, if UI related)

---

This change is 

[agentpietrucha]

This PR is built on top of the #3878 for better readability

[pronebird]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @mmsinclair, @neacsu, and @trojanfoe)

---

nym-vpn-core/crates/nym-vpn-api-client/src/client.rs line 176 at r1 (raw file):

    pub async fn get_remote_time(&self) -> Result<VpnApiTime> {
        #[cfg(test)]
        if let Some(mocked) = self.mock_remote_time.read().await.clone() {

This looks odd. Instead we should look into mocking api client

[agentpietrucha]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @mmsinclair, @neacsu, and @trojanfoe)

nym-vpn-core/crates/nym-vpn-api-client/src/client.rs line 176 at r1 (raw file):

    pub async fn get_remote_time(&self) -> Result<VpnApiTime> {
        #[cfg(test)]
        if let Some(mocked) = self.mock_remote_time.read().await.clone() {

This looks odd. Instead we should look into mocking api client

Could you elaborate more? Maybe with a little example?

[agentpietrucha]

I also about using httpmock::MockServer to mock the health response. Something like this:

server.mock(|when, then| {
    when.method(GET).path("/api/public/v1/health");
    then.status(200)
        .header("content-type", "application/json")
        .body(format!(r#"{{"status":"ok","timestampUtc":"{timestampUtc}"}}"#));
});

Do you prefer the MockServer approach?

[trojanfoe]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @mmsinclair, @neacsu, and @pronebird)

---

nym-vpn-core/crates/nym-vpn-api-client/src/client.rs line 176 at r1 (raw file):

Previously, agentpietrucha (Karol Sawicki) wrote…

Could you elaborate more? Maybe with a little example?

What Andrej is referring to is Dependency Injection, using the mocked object during testing and the real thing elsewhere.