[DNM] [native-prover] feat: canary #3350
Conversation
| // fp | ||
|
|
||
| #[napi] | ||
| #[napi(js_name = "caml_pasta_fp_poseidon_block_cipher")] |
There was a problem hiding this comment.
Mmmm actually is this the right format or should it be camel case in the napi annotation?
There was a problem hiding this comment.
this tells napi what name to use when exporting to js-land
There was a problem hiding this comment.
I was asking because when I was doing the plonk-wasm overrides for the first time, I had to create this snakeToCamel function in node_backend.js so that the function names coming from rust (in snake case) were mapped to camel case. So that makes me wonder if we could replace that whole function by just using #[napi(js_name = "camlPastaFpPoseidonBlockCipher")] in there.
There was a problem hiding this comment.
yeah, we don't need the snakeToCamel function if we do this here
Napi chooses to "snakeCase" your rust symbols by default, if we explicitly tell napi what name to give it, it will end up with this one guaranteed
|
closing this because #3357 is way better |
adding a canary value so we can ensure the e2e flow works