WIP: chore(Dep) bump k8s version to v1.32 #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zxw <[email protected]>
yyzxw
force-pushed
the
chore/bump-k8s-v1.32.2
branch
from
141dee2 to
04875b8
Compare
4 tasks
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 2 issues across 3 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
| k8s.io/kube-aggregator v0.27.2 | ||
| k8s.io/kube-openapi v0.0.0-20240228011516-70dd3763d340 | ||
| k8s.io/utils v0.0.0-20240711033017-18e509b52bc8 | ||
| k8s.io/kube-openapi v0.0.0-20241105132330-32ad38e42d3f |
There was a problem hiding this comment.
The pseudo-version contains a future timestamp (20241105), risking build failures because Go may refuse modules dated after the current time.
| sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.30.3 | ||
| sigs.k8s.io/apiserver-runtime v1.1.2-0.20221102045245-fb656940062f | ||
| sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.0 | ||
| sigs.k8s.io/apiserver-runtime v1.1.2-0.20250117204231-9282f514a674 |
There was a problem hiding this comment.
The pseudo-version timestamp (20250117) lies in the future, which can break reproducible builds and go mod tidy on machines whose clocks are correct because Go considers versions with future timestamps invalid or unreachable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait upstream pr: kubernetes-sigs/apiserver-runtime#122
Summary by cubic
Upgraded Kubernetes dependencies to v1.32.2 and updated related Go modules for compatibility.
Dependencies
Refactors
ctx.StopChwithctx.Context.Done()in loopback client initialization.