Swallow any errors when opportunistically looking up token names #2163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/suppress-useless-errors
branch
from
ea69204 to
be5668e
Compare
The custom logger will look for a specific flag on the request config, called "swallowError", and if it is set, swallow the error.
Any time we display an address, we want to check out if it has a token name. However, if it does not, we get a 404 error, and hence, a big ugly exception on the console. This change flags this request so that any error will be swallowed.
csillag
force-pushed
the
csillag/suppress-useless-errors
branch
from
be5668e to
8e088cc
Compare
Contributor
|
Claiming that app throws useless errors and we should swallow them is imo wrong direction. There is a bug. Bug is in |
Member
|
Maybe just be a bit stricter: if 404: swallow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any time we display an address, we want to check out if it has a token name. However, if no such token exists, we get a 404 error, and hence, a big ugly exception on the console, for each lookup attepmts. It looks like this:
This change makes it so that these errors are swallowed. (Not all token lookup errors, just the opportunistic ones, for finding out if they have a name.)
After this change, even in development mode, all we see on the console, after 5 look up attempts, is this: