-
Notifications
You must be signed in to change notification settings - Fork 148
go/control: Show local checkpoint heights #6265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
627efc8 to
747cdd3
Compare
747cdd3 to
0587cae
Compare
0587cae to
1bcd02f
Compare
970e3aa to
2222a19
Compare
go/consensus/cometbft/full/common.go
Outdated
|
|
||
| status.Checkpoint = n.fetchCheckpointStatus(ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you previously had checkpointer enabled (and you have some checkpoints), then you restart a node and disable checkpoints, you would still show old checkpoints. Could this confuse node operators?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also show information on whether the checkpointer is currently enabled or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also show information on whether the checkpointer is currently enabled or not.
You mean to only show it if the checkpointer is enabled? I think this would be good.
Alternative is to show the status of the checkpointer directly:
consensus.checkpointer.enabled/heights or possibly consensus.state.checkpointer.enabled/heights?
I notice for the consensus we tend to display "domain view" (current solution), whereas for the runtimes we tend to show status of independent components (alternative solution).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have kept is simple and only show it if checkpointer is enabled.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6265 +/- ##
==========================================
- Coverage 64.37% 64.36% -0.02%
==========================================
Files 697 697
Lines 67836 67854 +18
==========================================
+ Hits 43670 43674 +4
- Misses 19155 19171 +16
+ Partials 5011 5009 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
62b7642 to
1bc6907
Compare
1bc6907 to
e4e7863
Compare
e4e7863 to
66596ab
Compare
Closes #5823.
Overlap with oasisprotocol/docs#1363 (comment).