go/worker/storage: Refactor state sync worker pt1 #6306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
martintomazic
force-pushed
the
martin/trivial/state-sync-refactor
branch
4 times, most recently
from
a25e3c2 to
c22279e
Compare
Contributor
Author
|
For the non-synchronized documentation I should prepare a PR and merge intermediately after? |
martintomazic
requested review from
kostko,
peterjgilbert,
peternose,
pro-wh and
ptrus
as code owners
Contributor
Author
|
Let me fix the linting first and then I open it again. :) |
martintomazic
force-pushed
the
martin/trivial/state-sync-refactor
branch
from
c22279e to
ce420f1
Compare
martintomazic
commented
Aug 27, 2025
4 tasks
martintomazic
commented
Aug 27, 2025
peternose
reviewed
Aug 29, 2025
peternose
reviewed
Aug 29, 2025
martintomazic
force-pushed
the
martin/trivial/state-sync-refactor
branch
2 times, most recently
from
619ca25 to
b65ffef
Compare
martintomazic
force-pushed
the
martin/trivial/state-sync-refactor
branch
2 times, most recently
from
1f62446 to
b6a785c
Compare
martintomazic
commented
Sep 12, 2025
| ) | ||
|
|
||
| ctx, cancel := context.WithCancel(w.ctx) | ||
| ctx, cancel := context.WithTimeout(w.ctx, diffResponseTimeout) |
Contributor
Author
There was a problem hiding this comment.
Added this one as we discussed in the other threads by simply copying the client internal timeout (defensive).
But this should probably be reset per call or increased 2x given that is now used for calling legacy and new protocol internally...
update: tempted to drop this commit alltogether :).
Contributor
Author
There was a problem hiding this comment.
I moved this down to getDiff now and reset it.
martintomazic
force-pushed
the
martin/trivial/state-sync-refactor
branch
from
b6a785c to
2d5d1e0
Compare
peternose
approved these changes
Sep 12, 2025
| ctx, cancel := context.WithCancel(ctx) | ||
| defer cancel() | ||
|
|
||
| go func() { |
Contributor
Author
There was a problem hiding this comment.
I also removed redundant select in this go routine (captured by static check not part of our CI lint).
martintomazic
force-pushed
the
martin/trivial/state-sync-refactor
branch
2 times, most recently
from
08b1526 to
406b4ff
Compare
Also rename node to worker, to avoid confusion.
Previously, genesis checkpoint was created right after the state may be initialized from the runtime descriptor. If this is not the case it is first fetched from the peers. Thus, we should force the genesis checkpoint only after checkpoint sync finishes. Finally, redundant nil check was removed.
This is desirable, so that worker that initilize a new checkpointer don't require accepting context, but instead the lifetime and initialization of checkpointer is handled by the worker's Serve method.
Previously if the context was not canceled the fetcher might be sending the diffs on a channel that cannot be emptied, since we are already out of the main for loop, resulting in wg.Wait to never complete.
This also serves as step towards passing the context explicitly.
In addition, committee storage worker now implements the Service interface. The corresponding BackgroundService methods (already not used) have been removed. Similarly, the storage worker was internally refactored to Service interface to ease eventual removal of the BackgroundService. Additionally, observe that the parent (storage worker) is registered as background service, thus upon error inside committee worker there is no need to manually request the node shutdown. Finally, panicking has been replaced with error. Semantic changed slightly: Previously storage worker would wait for all committee workers to finish. Now it will terminate when the first one finishes. This was already the case if the committee worker panicked.
martintomazic
force-pushed
the
martin/trivial/state-sync-refactor
branch
from
406b4ff to
91ed0da
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6306 +/- ##
==========================================
+ Coverage 64.51% 64.56% +0.05%
==========================================
Files 697 698 +1
Lines 67847 67826 -21
==========================================
+ Hits 43770 43792 +22
+ Misses 19089 19046 -43
Partials 4988 4988 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done:
Follow-up:
I propose factoring out checkpointer and availability nudger (#6308) into separate workers. Could be one PR for each.
This will make diff sync part easier to reason about and thus optimize.