refactor: change to list of rose feeds and average price #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CrossChainPaymaster to support multiple ROSE/USD price feeds instead of a single feed, calculating an arithmetic mean of all valid feed prices for improved price reliability and resilience.
Key changes:
- Changed from single
roseUsdFeedto a set of feeds (_roseUsdFeeds) using OpenZeppelin'sEnumerableSet - Replaced
setRoseUsdFeedwithaddRoseUsdFeedandremoveRoseUsdFeedfunctions - Modified
_convertToRoseto aggregate prices from multiple feeds using arithmetic mean
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| contracts/contracts/sapphire/interfaces/ICrossChainPaymaster.sol | Updated interface to replace single feed events/functions with add/remove operations; added new error types and getter methods for the feed set |
| contracts/contracts/sapphire/CrossChainPaymaster.sol | Implemented EnumerableSet for storing multiple ROSE/USD feeds; refactored price conversion to calculate mean across all valid feeds with graceful error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rube-de
force-pushed
the
rube/7-add-function-to-get-mean-average-rose-price-form-price-feeds
branch
from
8af077b to
d7308cc
Compare
matevz
reviewed
Nov 14, 2025
contracts/tasks/paymaster/deploy/deploy-cross-chain-paymaster.ts
Outdated
Show resolved
Hide resolved
rube-de
force-pushed
the
rube/7-add-function-to-get-mean-average-rose-price-form-price-feeds
branch
from
eb24507 to
a33b225
Compare
matevz
approved these changes
Dec 11, 2025
rube-de
deleted the
rube/7-add-function-to-get-mean-average-rose-price-form-price-feeds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.