Add badgerdb-analyzer tool for analyzing consistency of Oasis node snapshots #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+59
to
+65
| opts.NumCompactors = 0 | ||
| opts.CompactL0OnClose = false | ||
| opts.BypassLockGuard = true // Allow concurrent access | ||
| opts.DetectConflicts = false // Reduce overhead | ||
| // Keep default logger enabled for diagnostics | ||
|
|
||
| db, err = badger.Open(opts) |
There was a problem hiding this comment.
Using normal mode (badger.Open) might be risky, as during node lifetime, mkvs databases are opened in the managed mode (badger.OpenManaged). Other databases are always opened in the normal mode. E.g opening consensus-mkvs in normal mode and forcing compaction results in data loss.
But you also set opts.NumCompactors = 0 so this should be probably safe. Have you observed any such issues? If not I would just add a comment/warning that this combo should be never changed or we risk data loss.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a tool for analyzing and checking the consistency of BadgerDB databases from Oasis node snapshots. It performs a full database scan, analysis with statistics, consistency validation, and integrity checks. It handles multiple BadgerDB versions (v2-v4) and data representations use by Oasis nodes (v20.x-v25.x). Works on majority of data.