Skip to content

Add a security note about signing apks in CI #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukaw3d merged 2 commits into from
Jan 6, 2026
Merged

Add a security note about signing apks in CI #2242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d86485
Move AAB and APK signing steps together
lukaw3d Dec 4, 2025
4f4dabf
Add a security note about signing apks in CI
lukaw3d Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/2242.trivial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add a security note about signing apks in CI
18 changes: 9 additions & 9 deletions .github/workflows/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,22 +70,22 @@ jobs:
if: github.event_name == 'push'
run: ./gradlew assembleRelease -PversionCodeOverride=${{ steps.vars.outputs.VERSION_CODE_OVERRIDE }}
working-directory: android
- name: Decode and Save Keystore File
if: github.event_name == 'push'
run: |
echo "${{ secrets.KEYSTORE_FILE }}" | base64 --decode > "android/release.jks"
- name: Sign AAB using jarsigner
if: github.event_name == 'push'
run: |
jarsigner -verbose -keystore "android/release.jks" -storepass "${{ secrets.KEYSTORE_PASSWORD }}" -keypass "${{ secrets.KEYSTORE_PASSWORD }}" -signedjar "android/app/build/outputs/bundle/release/app-release-signed.aab" "android/app/build/outputs/bundle/release/app-release.aab" "${{ secrets.KEY_ALIAS }}"
# Targeting version 30 and above we need to align the APK so that all uncompressed data starts on a 4-byte boundary
- name: Zipalign APK
if: github.event_name == 'push'
run: |
"$ANDROID_SDK_ROOT/build-tools/35.0.0/zipalign" -v 4 "android/app/build/outputs/apk/release/app-release-unsigned.apk" "android/app/build/outputs/apk/release/app-release-aligned.apk"
- name: Sign APK using apksigner
- name: Decode and Save Keystore File
if: github.event_name == 'push'
run: |
echo "${{ secrets.KEYSTORE_FILE }}" | base64 --decode > "android/release.jks"
- name: Sign AAB and APK
# Security: should not sign apks on unmerged pullrequest. Otherwise someone
# could sign a malicious app and distribute it with our valid signature (though
# outside playstore).
if: github.event_name == 'push'
run: |
jarsigner -verbose -keystore "android/release.jks" -storepass "${{ secrets.KEYSTORE_PASSWORD }}" -keypass "${{ secrets.KEYSTORE_PASSWORD }}" -signedjar "android/app/build/outputs/bundle/release/app-release-signed.aab" "android/app/build/outputs/bundle/release/app-release.aab" "${{ secrets.KEY_ALIAS }}"
"$ANDROID_SDK_ROOT/build-tools/35.0.0/apksigner" sign --ks "android/release.jks" --ks-pass "pass:${{ secrets.KEYSTORE_PASSWORD }}" --key-pass "pass:${{ secrets.KEYSTORE_PASSWORD }}" --ks-key-alias "${{ secrets.KEY_ALIAS }}" "android/app/build/outputs/apk/release/app-release-aligned.apk"
- name: Upload Android AAB build artifacts
if: github.event_name == 'push'
Expand Down