Enhance: Add ability to do inline prompt to choose oauth/pat #2305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
commented
Mar 26, 2025
pkg/render/render.go
Outdated
| } | ||
|
|
||
| extraEnv = append(extraEnv, oauthEnv...) | ||
| extraEnv = append(extraEnv, fmt.Sprintf("OAUTH_SERVER_URL=%s", oauthServerURL)) |
There was a problem hiding this comment.
dropping all the existing env url that we are passing down to the oauth tool. It is no longer needed(used to determine whether tool need to do oauth or not) and oauth tool can figure out the url by itself given the server url. obot-platform/tools@156b7bd#diff-9ae2ae74ccd09b47849da90bbe83ab989b5cf7bdc4d074c82046370972269defR78
StrongMonkey
commented
Mar 26, 2025
| name={field.name} | ||
| bind:value={promptCredentials[field.name]} | ||
| /> | ||
| {#if field.options} |
There was a problem hiding this comment.
new ui components to handle field with options. For now, it is buttons but we can customize it to be dropdowns
StrongMonkey
commented
Mar 26, 2025
| <dialog bind:this={dialog} class="h-1/4 min-h-[300px] w-1/3 min-w-[300px] overflow-visible p-5"> | ||
| <dialog | ||
| bind:this={dialog} | ||
| class="max-h-[90vh] min-h-[300px] w-1/3 min-w-[300px] overflow-visible p-5" |
There was a problem hiding this comment.
fix the dialog not extending :)
g-linville
approved these changes
Mar 27, 2025
StrongMonkey
force-pushed
the
oauth-pat
branch
2 times, most recently
from
30ae6c0 to
88391e8
Compare
Signed-off-by: Daishan Peng <[email protected]>
tybalex
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to support inline prompt to allow user to select oauth/pat in tools. It drops the existing oauth env variables we use and in oauth tool add ability to prompt user to select auth type.
https://www.loom.com/share/e73f61cd9c884607be592ed7d34d89ba
#2140
need
gptscript-ai/go-gptscript#96
gptscript-ai/gptscript#955
obot-platform/tools#536