fix: disable copy button when clipboard is unavailable #3447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`navigator.clipboard` is unavailable in insecure contexts (like non-localhost http). This results in the copy button not working. Detect this scenario and disable the copy button. Addresses obot-platform#3433 Note: I'm not sure this is actually how we want to handle this. I can try another method to make this work in these contexts, but wanted to gather feedback on this approach first. Signed-off-by: Nick Hale <[email protected]>
njhale
requested review from
thedadams,
ivyjeong13,
tybalex,
StrongMonkey and
g-linville
g-linville
approved these changes
Jul 18, 2025
ivyjeong13
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Looks like navigator.clipboard is appropriate, https://developer.mozilla.org/en-US/docs/Web/API/Navigator/clipboard says it's only available in secure contexts. Was wondering are there cases where we would want to avoid copying in a secure context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
navigator.clipboardis unavailable in insecure contexts (likenon-localhost http). This results in the copy button not working.
Detect this scenario and disable the copy button.
Addresses #3433
Note: I'm not sure this is actually how we want to handle this. I can
try another method to make this work in these contexts, but wanted to
gather feedback on this approach first.