-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[new release] repr (4 packages) (0.8.0) #28963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
CHANGES: - Bump ppxlib to `>=0.36.2` (mirage/repr#110, @patricoferris) - Update to ocamlformat 0.28.1 (mirage/repr#110, @patricoferris) - Fix `short_hash` signature for ppx_repr deriver (mirage/repr#109, @mattiasdrp)
|
Thanks @samoht for getting this out the door! Looking at the CI I see we will need:
|
jmid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repr-fuzzis failing during the lower-bound check I think, I don't quite understand how the lower-bound bit works to be honest as there is still a dependency onrepr=0.8.0which should keep the lower-bound tight for ppxlib but it seems this is not the case? A quick fix for CI would just be the also addppxlib >= 0.36.2torepr-fuzz.
Indeed, there's a lower-bound failure.
I don't follow you on the tight lower bound for repr=0.8.0 though.
AFAICS, in https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/913ae0345c6304f0663d1c952f124a1bcdb7ee1d/variant/compilers,4.13,repr-fuzz.0.8.0,lower-bounds it keeps repr=0.8.0, but that one has no ppxlib dependency 🤔
Unrelated, would you consider adding x-maintenance-intent entries for the packages?
https://github.com/ocaml/opam-repository/blob/master/governance/policies/archiving.md
|
I've now opened #28993 to address the |
|
I restarted the CI now that #28993 has been merged. |
|
CI is now down to just 3 opam-2.0 failures, so this is shaping up. 🎉 Would you consider adding |
Dynamic type representations. Provides no stability guarantee
CHANGES:
>=0.36.2(5.2 ast bump mirage/repr#110, @patricoferris)short_hashsignature for ppx_repr deriver (Ppx_repr: short_hash signature deriver fix mirage/repr#109, @mattiasdrp)