Skip to content

Conversation

@btupper
Copy link

@btupper btupper commented Aug 15, 2022

Script iterates through the packages identified in the YAML, returns non-zero early if an issue is encountered.

Copy link
Collaborator

@abkfenris abkfenris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that would be a nice change for installing R packages.

I think it's missing a step to copy the install script into the container before running.

Adds script copy

Co-authored-by: Alex Kerney <[email protected]>
@abkfenris
Copy link
Collaborator

And need to copy remotes.yml in too.

Co-authored-by: Alex Kerney <[email protected]>
@abkfenris
Copy link
Collaborator

Hmm, I just tried running it locally with a fake package name to see how it failed, and it just kept going instead.

@btupper
Copy link
Author

btupper commented Aug 16, 2022 via email

@btupper
Copy link
Author

btupper commented Aug 16, 2022

OK - looks like a brainless call to library(packagename) after the install() will help throw a real error. Of course, it is meaningless if the you are trying to re-install an existing package; let's ignore that limitation!

https://stackoverflow.com/questions/26244530/how-do-i-make-install-packages-return-an-error-if-an-r-package-cannot-be-install

I'll patch it up and try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants