fix(css-load): fix useCssLoadPatch determination when encountering unknown UA + platforms #417
Conversation
…known UA strings Requires rebuild post-merge. Fixes ocombe#416
booleanbetrayal
changed the title
| // Safari < 6 | ||
| var versionMatch = ua.match(/version\/([\.\d]+)/i); | ||
| useCssLoadPatch = (versionMatch && versionMatch[1] && parseFloat(versionMatch[1]) < 6); | ||
| try { |
There was a problem hiding this comment.
wrapped in try-catch with no other changes
|
Wondering if you had chance to take a look at this @ocombe |
|
any thoughts, @ocombe ? we're seeing this fail fairly frequently with the code that's in master. |
|
@booleanbetrayal Did you build and test this? I'm having a similar issue, but I have no idea what tool is used to build this. Just manually added it to the main js file and minified version. Can confirm issue is fixed; however, my ocLazyLoad was also insanely outdated on v0.6.3 |
|
I haven't tried to build this but I could. Is that something I should do @ocombe ? |
|
Added dist builds to this branch @daerogami via 0b785e6 |
|
Awesome! It will be a week or so before I can get around to testing this on the project I'm using it on. Thanks @booleanbetrayal! |
2 participants
Requires rebuild post-merge.
Fixes #416