Skip to content

Conversation

@chgo-odoo
Copy link
Contributor

@chgo-odoo chgo-odoo commented Jan 17, 2025

Requires :


*: anelusia, artists, avantgarde, aviato, beauty, bewise, bistro, bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace, monglia, nano, notes, odoo_experts, orchid, paptic, real estate, treehouse, vehicle, yes, zap

This PR adapts all the xpath expressions inside design themes to target the new heading tags that were changed within the snippet files.

task-4349019

@robodoo
Copy link
Collaborator

robodoo commented Jan 17, 2025

Pull request status dashboard

@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 3 times, most recently from bb5de82 to 1e15873 Compare February 10, 2025 08:37
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 6 times, most recently from e20a929 to 52b8cd3 Compare February 12, 2025 08:30
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 6 times, most recently from 8b28770 to 012a09e Compare March 6, 2025 12:11
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 6 times, most recently from 572f1f3 to 6c50db1 Compare June 25, 2025 13:05
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch from 6c50db1 to 2386fe2 Compare July 2, 2025 08:02
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch 5 times, most recently from a11e6cf to db0c38a Compare August 21, 2025 11:06
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch from 4fd527f to 6e9c041 Compare August 28, 2025 13:50
@chgo-odoo chgo-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch from 6e9c041 to f0073ac Compare August 28, 2025 13:51
@chgo-odoo chgo-odoo changed the title [FIX] theme_aviato: adapt s_popup xpath [IMP] theme_*: improve SEO by correcting heading tag hierarchy Aug 28, 2025
@chgo-odoo chgo-odoo requested a review from qsm-odoo August 28, 2025 13:58
* anelusia, artists, avantgarde, aviato, beauty, bewise, bistro,
bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace,
monglia, nano, notes, odoo_experts, orchid, paptic, real estate,
treehouse, vehicle, yes, zap

This commit adapts all the `xpath` expressions inside design themes to
target the new heading tags that were changed within the snippet files.

task-4349019
@qsm-odoo qsm-odoo force-pushed the master-website-finetune-snippets-heading-chgo branch from f0073ac to fe78996 Compare September 8, 2025 10:27
Copy link
Contributor

@qsm-odoo qsm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That must have been an annoying work 😬 Good job ;)

@robodoo r+

robodoo pushed a commit that referenced this pull request Sep 8, 2025
* anelusia, artists, avantgarde, aviato, beauty, bewise, bistro,
bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace,
monglia, nano, notes, odoo_experts, orchid, paptic, real estate,
treehouse, vehicle, yes, zap

This commit adapts all the `xpath` expressions inside design themes to
target the new heading tags that were changed within the snippet files.

task-4349019

closes #1043

Related: odoo/odoo#191300
Related: odoo/enterprise#92978
Signed-off-by: Quentin Smetz (qsm) <[email protected]>
robodoo pushed a commit to odoo/odoo that referenced this pull request Sep 8, 2025
Complete list of snippets :
s_attributes_horizontal, s_call_to_action, s_card, s_card_offset,
s_card_offset, s_cards_grid, s_cards_soft, s_carousel, s_carousel_cards,
s_company_team, s_company_team_basic, s_company_team_detail,
s_company_team_spotlight, s_comparisons, s_cta_card, s_cta_mobile,
s_cta_mockups, s_faq_collapse, s_faq_list, s_features, s_features_grid,
s_features_wave, s_image_frame, s_image_text_box, s_masonry_block,
s_numbers, s_numbers_charts, s_numbers_list, s_showcase,
s_table_of_content, s_text_highlight, s_three_columns, s_title

Some snippets in website were using inconsistent heading levels
(e.g. h2 directly followed by h6), which harmed both accessibility and
SEO. This commit standardizes the heading hierarchy inside snippets to
ensure a logical structure.

This improves:

1. Natural SEO ranking by providing clearer semantic signals to search
engines.

2. Accessibility for screen readers that rely on a consistent heading
order.

3. Overall readability and maintainability of the themes.

Note that the we preserved the design by applying a `.h*-fs` class
that matches the old heading tag in use.

We also fixed selectors inside tests and adapted the new page templates

task-4349019

closes #191300

Related: odoo/enterprise#92978
Related: odoo/design-themes#1043
Signed-off-by: Quentin Smetz (qsm) <[email protected]>
robodoo pushed a commit that referenced this pull request Sep 8, 2025
* anelusia, artists, avantgarde, aviato, beauty, bewise, bistro,
bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace,
monglia, nano, notes, odoo_experts, orchid, paptic, real estate,
treehouse, vehicle, yes, zap

This commit adapts all the `xpath` expressions inside design themes to
target the new heading tags that were changed within the snippet files.

task-4349019

closes #1043

Related: odoo/odoo#191300
Related: odoo/enterprise#92978
Signed-off-by: Quentin Smetz (qsm) <[email protected]>
@robodoo robodoo added the 18.5 label Sep 8, 2025
@robodoo robodoo closed this Sep 8, 2025
@qsm-odoo qsm-odoo deleted the master-website-finetune-snippets-heading-chgo branch September 8, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants