[IMP] essentials: extra detail plus updates to favorited searches

[fw-bot]

task-5005364

Forward-Port-Of: #14285

[robodoo]

[fw-bot]

This PR targets saas-18.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

[fw-bot]

@mcsi-odoo @auva-odoo this PR was modified / updated and has become a normal PR. It must be merged directly.

[auva-odoo]

Thank you @mcsi-odoo! Feel free to reach out if you’d like any help with my comment on line 274. The rest are just minor comments 🙂

[auva-odoo]

Isn't it easier (and a bit faster) to edit the favorite the way you described for 18.0? --> hover over the :icon:fa-star :guilabel:(star) icon beside the search name in the search bar, then click the :icon:fa-cog
:guilabel:(cog) icon. Modify the conditions as needed, then click :guilabel:Confirm.

And then mention this as an alternative?

EDIT: actually, I'm not sure: if we enable the developer mode before performing the steps you originally described here, users can also edit the "group by" option, which I think could be worth mentioning? I'd suggest adding this (the developer mode part) in a tip but I'm not sure; what do you think?

And also don't forget the brackets for the icon's descriptor:

Suggested change

	To edit or delete a favorited search, hover over the search name in the list of favorites and click
	:icon:`fa-pencil` :guilabel:`Edit favorite`. Modify any element of the favorite as desired.
	To edit or delete a favorited search, hover over the search name in the list of favorites and click
	:icon:`fa-pencil` (:guilabel:`Edit favorite`). Modify any element of the favorite as desired.

[mcsi-odoo]

Thanks for the feedback!

I opted to focus on this (new) way of editing(/deleting) since it gives many more options - the 'shorter' way doesn't let you edit the name of the favourite, whether or not it's the default filter, or who it's shared with (if anyone).

So, I would prefer to keep the current approach (but add which fields can be updated when editing the 'long' way), and maybe mention the other, 'shorter' way in a tip, noting that it's only for editing the domain, conditions.

As for your suggestion about adding a tip about enabling debug mode to be able to modify grouping (nice, I hadn't figured that out) ... I'm not sure. I feel like then we'd need some detail on how the 'context' and 'sort' should be completed to add grouping/sorting info (I'd also be ending up with a LOT of tips, as usual ;))

[auva-odoo]

• Regarding the way of editing saved searches; this makes sense to me! And yes we can add the "shorter" way in the tip just in case.
• Regarding the context; I think we could add this info in your last list item in the tip since we can also edit the context/sort options from the user-defined filters (which already involve enabling the debug mode). I think this item is intended for more advanced users anyways (like everything in the Technical menu) and we could argue that because of this, we can just justify mentioning these fields without going into more details. That way if people do wonder how they can change the group by options, they know where to look at least? Does this make sense?

[mcsi-odoo]

I just realised I had misunderstood something: you can't actually edit a favorited search 'the short way' ... any changes you make there only impact the current search. It would seem that until 18.3, the only way to edit a favorited search was via the Technical menu.

So, I need to do a new PR to correct that ... one that only fw-ports to 18.2.

[auva-odoo]

@robodoo r+