Skip to content

Conversation

@theRealThagomizer
Copy link
Contributor

Hiya, Felicia! Got a 2 pt. PR related to the certification questions. This PR adds a new section to the Product Variants page that explains what happens when attributes are added or deleted to existing variants.

This 19.0 PR can be FWP up to master.

@robodoo
Copy link
Collaborator

robodoo commented Nov 18, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team November 18, 2025 22:21
Comment on lines +302 to +304
Adding and deleting attributes from product variants
====================================================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool troubleshooting section and documenting an edge case! To better conceptualize the impact, let's use an example. Start with some attributes with multiple values, add 1 attribute value to an order, then delete the attribute, and show that the attribute value that was never used gets deleted and the value that was used gets archived (and specify where)

@theRealThagomizer theRealThagomizer force-pushed the 19.0-adding-deleting-attributes-thjud branch from 596b012 to 33495da Compare November 21, 2025 03:12
Comment on lines 317 to 318
A business offers leather jackets with a variety of customization options: size, color, and
material. They sell standard leather jackets and limited edition leather jackets as two different
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking here so we're really precise with the language about what an attribute vs value is

Suggested change
A business offers leather jackets with a variety of customization options: size, color, and
material. They sell standard leather jackets and limited edition leather jackets as two different
A business offers leather jackets with a variety of customization attributes: size, color, and
material. Each attribute has multiple values: for size, there is S, M, L. They sell standard leather jackets and limited edition leather jackets as two different

.. example::
A business offers leather jackets with a variety of customization options: size, color, and
material. They sell standard leather jackets and limited edition leather jackets as two different
products. The standard leather jackets are a best-selling item, but the limited edition jackets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean that "They sell standard leather jackets and limited edition leather jackets as two different products"? In Odoo, we can set different prices for product variants, but this sentence makes it sound like there are two separate products, which would be a concept different from variants. Could you clarify what you mean here?

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate=theRealThagomizer

@theRealThagomizer theRealThagomizer force-pushed the 19.0-adding-deleting-attributes-thjud branch from 33495da to 9712840 Compare November 21, 2025 22:09
@theRealThagomizer
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 22, 2025
closes #15351

Signed-off-by: Thomas Jude Cavazos (thjud) <[email protected]>
Co-authored-by: Felicia Kuan <[email protected]>
robodoo pushed a commit that referenced this pull request Nov 22, 2025
closes #15351

Signed-off-by: Thomas Jude Cavazos (thjud) <[email protected]>
Co-authored-by: Felicia Kuan <[email protected]>
robodoo pushed a commit that referenced this pull request Nov 22, 2025
closes #15351

Signed-off-by: Thomas Jude Cavazos (thjud) <[email protected]>
Co-authored-by: Felicia Kuan <[email protected]>
@robodoo robodoo closed this in ef914ef Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants