-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[IMP] Sales: adding/deleting variants clarification #15351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Adding and deleting attributes from product variants | ||
| ==================================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool troubleshooting section and documenting an edge case! To better conceptualize the impact, let's use an example. Start with some attributes with multiple values, add 1 attribute value to an order, then delete the attribute, and show that the attribute value that was never used gets deleted and the value that was used gets archived (and specify where)
596b012 to
33495da
Compare
| A business offers leather jackets with a variety of customization options: size, color, and | ||
| material. They sell standard leather jackets and limited edition leather jackets as two different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking here so we're really precise with the language about what an attribute vs value is
| A business offers leather jackets with a variety of customization options: size, color, and | |
| material. They sell standard leather jackets and limited edition leather jackets as two different | |
| A business offers leather jackets with a variety of customization attributes: size, color, and | |
| material. Each attribute has multiple values: for size, there is S, M, L. They sell standard leather jackets and limited edition leather jackets as two different |
| .. example:: | ||
| A business offers leather jackets with a variety of customization options: size, color, and | ||
| material. They sell standard leather jackets and limited edition leather jackets as two different | ||
| products. The standard leather jackets are a best-selling item, but the limited edition jackets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean that "They sell standard leather jackets and limited edition leather jackets as two different products"? In Odoo, we can set different prices for product variants, but this sentence makes it sound like there are two separate products, which would be a concept different from variants. Could you clarify what you mean here?
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo delegate=theRealThagomizer
Co-authored-by: Felicia Kuan <[email protected]>
33495da to
9712840
Compare
|
@robodoo r+ |
closes #15351 Signed-off-by: Thomas Jude Cavazos (thjud) <[email protected]> Co-authored-by: Felicia Kuan <[email protected]>
closes #15351 Signed-off-by: Thomas Jude Cavazos (thjud) <[email protected]> Co-authored-by: Felicia Kuan <[email protected]>
closes #15351 Signed-off-by: Thomas Jude Cavazos (thjud) <[email protected]> Co-authored-by: Felicia Kuan <[email protected]>

Hiya, Felicia! Got a 2 pt. PR related to the certification questions. This PR adds a new section to the Product Variants page that explains what happens when attributes are added or deleted to existing variants.
This 19.0 PR can be FWP up to master.