-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[WIP] update suggest documentation #15368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
|
Appreciate your initiative with this PR, @jeanschoenlaub ! @jero-odoo is the content owner for the Purchase app, so feel free to tag her for review whenever it's ready! (: |
4034a39 to
f8d58c0
Compare
f8d58c0 to
1f24587
Compare
|
Hey @jero-odoo, this is my first doecumentation PR, so please let me know if there is anything I missed / could be doing better. Thanks :). |
jero-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeanschoenlaub , This looks great! I added a few notes (mostly formatting), let me know if you have any questions.
Also, it looks like there are two images in the folder that are no longer needed in the doc (suggest-30.png and in-field.png) that should be removed. Thanks!
| Once the parameters are confirmed, click :guilabel:`Compute` to calculate recommended quantities, | ||
| which are auto-filled in each product's quantities in the catalog. Adjust amounts if needed, then | ||
| click :guilabel:`Back to Quotation` to confirm the final numbers on the |RFQ|. | ||
| Once the parameters are confirmed, click :guilabel:`Add All` to add all suggestion to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Once the parameters are confirmed, click :guilabel:`Add All` to add all suggestion to the | |
| Once the parameters are confirmed, click :guilabel:`Add All` to add all suggestions to the |
| appears. Choose a specific warehouse or leave blank to use all warehouses to calculate demand | ||
| accordingly. | ||
| <../../manufacturing/subcontracting/subcontracting_resupply>` coming from the warehouse specified | ||
| on the RFQ in the *Based on* period. The *average daily demand* is this sum of out-going moves |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| on the RFQ in the *Based on* period. The *average daily demand* is this sum of out-going moves | |
| on the RFQ in the *Based on* period. The *average daily demand* is this sum of outgoing moves |
| numbers on the |RFQ|. | ||
|
|
||
| .. _purchase/advanced/example-suggestion: | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the next two sections act as an example workflow, I would add a new H2 heading here (Example Workflow), to make it clearer.
|
That's so sweet, @jeanschoenlaub! Thank you for the compliment 😊 The writing was great, and most importantly, you followed our RST conventions and style guide, so there wasn't too much for us to do! Our team values collaborating and communicating with the R&D team that's developing the features, and we're truly grateful that you're taking the initiative to write such a detailed changelog in the PR description and updating the documentation 😊 So happy to collaborate with you and (not to sound ungrateful) we hope this won't be your last contribution to the docs repo! 😉 After applying @jero-odoo's feedback, feel free to merge after the checks pass! @robodoo delegate=jeanschoenlaub |

The suggest feature UX and business logic has changed quite a bit and I thought it should be reflected in the documentation.
UX changes:
---> Changed the text (eg. "click" -> "toggle")
---> Changed 2 screenshots illustrating the suggestion results.
---> Removed 1 screenshot of the wizard itself (removed not replaced because both the result and the inputs can now be seen in the same screenshot).
Business logic change:
---> Replaced a section on multi warehouse setup with a tip on demand calculation case with a sample multi warehouse setup
Also added (even though this hasn't changed):