[IMP] excise_management : Deposit & excise totals by line #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dhrs-odoo
force-pushed
the
19.0-excise_management-update-dhrs
branch
4 times, most recently
from
9fdbd52 to
4be4c3b
Compare
dhrs-odoo
force-pushed
the
19.0-excise_management-update-dhrs
branch
from
4be4c3b to
fc89276
Compare
vava-odoo
reviewed
Oct 17, 2025
| <field name="field_description">Excise Free Unit Price</field> | ||
| <field name="model_id" ref="sale.model_sale_order_line"/> | ||
| <field name="ttype">monetary</field> | ||
| <field name="depends">price_unit, tax_ids</field> |
There was a problem hiding this comment.
why tax_ids and not product_id?
| </record> | ||
| <record id="account_tax_deposit_field" model="ir.model.fields"> | ||
| <field name="name">x_is_deposit</field> | ||
| <field name="field_description">Is Deposit</field> |
There was a problem hiding this comment.
There is already a similar field on account.tax.group. But it is hidden. Maybe we should just display this one instead, and use when needed.
| <field name="active" eval="True"/> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//page[@name='order_lines']//list//field[@name='tax_ids']" position="after"> | ||
| <field optional="show" name="x_excise_free_unit_price" invisible="not x_excise_free_unit_price"/> |
There was a problem hiding this comment.
if I get the spec correctly, there should be a column_invisible condition as well
| 'depends': [ | ||
| 'account_tax_python', | ||
| 'base_automation', | ||
| 'sale_management', |
There was a problem hiding this comment.
could you bump the minor version of all modules?
| </field> | ||
| </record> | ||
| <record id="sale_order_form_view_customizations" model="ir.ui.view"> | ||
| <field name="name">sale.order.form customization</field> |
There was a problem hiding this comment.
Suggested change
| <field name="name">sale.order.form customization</field> | |
| <field name="name">sale.order.form.inherit.excise_management</field> |
| <field name="state">code</field> | ||
| <field name="name">Add/Remove excise tax on Fiscal Position</field> | ||
| </record> | ||
| <record id="requence_the_order_of_taxes" model="ir.actions.server"> |
| <field name="name">Add/Remove excise tax on Fiscal Position</field> | ||
| </record> | ||
| <record id="requence_the_order_of_taxes" model="ir.actions.server"> | ||
| <field name="code"><![CDATA[all_taxes = env['account.tax'].sudo().search([], order="x_is_deposit asc, x_is_excise desc, sequence asc") |
There was a problem hiding this comment.
Instead of a search + write on all taxes, couldn't we find a better way? Like assigning the same sequence than another excise/deposit tax
This way looks too costly to me
| <field name="field_description">Excises</field> | ||
| <field name="model_id" ref="sale.model_sale_order_line"/> | ||
| <field name="ttype">monetary</field> | ||
| <field name="depends">product_id, product_uom_qty</field> |
There was a problem hiding this comment.
Suggested change
| <field name="depends">product_id, product_uom_qty</field> | |
| <field name="depends">product_id, product_uom_qty, order_id.fiscal_position_id</field> |
| <field name="field_description">Deposits</field> | ||
| <field name="ttype">monetary</field> | ||
| <field name="model_id" ref="sale.model_sale_order_line"/> | ||
| <field name="depends">price_unit, product_uom_qty, tax_ids.x_is_deposit</field> |
There was a problem hiding this comment.
we won't update on SOL if a tax is modified, only if the tax is (un)assign to the SOL
Suggested change
| <field name="depends">price_unit, product_uom_qty, tax_ids.x_is_deposit</field> | |
| <field name="depends">product_uom_qty, tax_ids</field> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we have made customizations to display deposit & excise totals by line.
Task-5127418