[FIX] side panel: close selection input when switching tab #7488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
When focusing the selection input in the chart side panel, changing tab would not close the selection input, even though the input isn't visible anymore. It's because since 91c0583, changing the tab would keep the component mounted, only hiding it with `d-none` (to keep its state). Relying on the selection input `onWillUnmount` to reset the state is not enough. We now rely on a `useEffect` that checks the `input.offsetParent` property, which is `null` when an ancestor has `display: none`. Task: 5249165
hokolomopo
force-pushed
the
19.0-fix-selection-input-unmount-adrm
branch
from
a45ab1f to
c039286
Compare
rrahir
reviewed
Nov 21, 2025
| // offsetParent should return the nearest positioned ancestor, or null if an ancestor has `display: none` | ||
| jest | ||
| .spyOn(HTMLElement.prototype, "offsetParent", "get") | ||
| .mockImplementation(function (this: HTMLElement) { |
Collaborator
There was a problem hiding this comment.
did you have a look at jsdom/jsdom#1261, the polyfill suggested seems to stick close to the spec I could see on MDN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When focusing the selection input in the chart side panel, changing tab would not close the selection input, even though the input isn't visible anymore.
It's because since 91c0583, changing the tab would keep the component mounted, only hiding it with
d-none(to keep its state). Relying on the selection inputonWillUnmountto reset the state is not enough.We now rely on a
useEffectthat checks theinput.offsetParentproperty, which isnullwhen an ancestor hasdisplay: none.Task: 5249165
Task: 5249165
review checklist