[FIX] spreadsheet: dark mode display issues #7533
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update rotation icons to use `currentColor` so they follow the active theme palette. - Force data bar conditional format preview text to use the dark `TEXT_BODY` color, regardless of theme, as it was previously changing with the theme and becoming hard to read. Task: 5322179
Collaborator
|
|
dhrp-odoo
commented
Nov 26, 2025
Comment on lines
+43
to
+45
| const barColor = colorNumberToHex(rule.color); | ||
| const gradient = `background-image: linear-gradient(to right, ${barColor} 50%, white 50%)`; | ||
| return `${gradient}; color: ${TEXT_BODY};`; |
Contributor
Author
There was a problem hiding this comment.
I don’t think this is actually an issue. The text color should be white and the preview’s right-side background should be black to match the grid, so that users get an accurate idea of how the data bar will look.
Since the dark grid hasn’t been implemented yet, it’s probably better to address this as part of that task ???
Contributor
There was a problem hiding this comment.
Yeah the preview will need to be adapted when we implement the grid in dark theme. In the meantime, we should match the grid as you said, so a black text is probably better :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
currentColorso they follow the active theme palette.TEXT_BODYcolor, regardless of theme, as it was previously changing with the theme and becoming hard to read.Task: 5322179
review checklist