Skip to content

[FIX] chart: don't crash treemap without visible data #7549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FIX] chart: don't crash treemap without visible data #7549

wants to merge 1 commit into from
+26 −0

Conversation

@LucasLefevre
Copy link
Collaborator

@LucasLefevre LucasLefevre commented Nov 27, 2025

Steps to reproduce:

  • in A1: "Year"
  • in B1: "2025"
  • create a tree map chart with Hierachy: A1 and Values: B1
  • go to the design panel
  • change it to "Color scale"
  • hide column B

=> Crash

Task: 5365419
opw-5166581

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Nov 27, 2025

Pull request status dashboard

@LucasLefevre
[FIX] chart: don't crash treemap without visible data
cda051f 
Steps to reproduce:
- in A1: "Year"
- in B1: "2025"
- create a tree map chart with Hierachy: A1 and Values: B1
- go to the design panel
- change it to "Color scale"
- hide column B

=> Crash

opw-5166581
Task: 5365419
@LucasLefevre LucasLefevre force-pushed the saas-18.4-treemap-hidden-data-lul branch from 9256604 to cda051f Compare November 27, 2025 15:55
pro-odoo
pro-odoo approved these changes Dec 1, 2025
View reviewed changes
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Dec 1, 2025
@LucasLefevre
[FIX] chart: don't crash treemap without visible data
ecb26f8 
Steps to reproduce:
- in A1: "Year"
- in B1: "2025"
- create a tree map chart with Hierachy: A1 and Values: B1
- go to the design panel
- change it to "Color scale"
- hide column B

=> Crash

opw-5166581

closes #7549

Task: 5365419
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
@robodoo robodoo closed this Dec 1, 2025
This was referenced Dec 1, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pro-odoo pro-odoo pro-odoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LucasLefevre @robodoo @pro-odoo