Skip to content

Conversation

@fda-odoo
Copy link
Collaborator

@fda-odoo fda-odoo commented Oct 1, 2025

No description provided.

@fda-odoo fda-odoo added this to the 1.1.0 milestone Oct 1, 2025
@fda-odoo fda-odoo self-assigned this Oct 1, 2025
@fda-odoo fda-odoo added the enhancement New feature or request label Oct 1, 2025
@fda-odoo fda-odoo force-pushed the alpha-imports-fda branch 2 times, most recently from df45d29 to 94f2843 Compare October 6, 2025 16:05
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

⚠️ The file 'Cargo.toml or constant.rs' has been modified in this PR. Please review the changes carefully.
⚠️ A 'println!(' statement was found in the commit. Please ensure debug statements are removed before merging.

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

⚠️ The file 'Cargo.toml or constant.rs' has been modified in this PR. Please review the changes carefully.
⚠️ A 'println!(' statement was found in the commit. Please ensure debug statements are removed before merging.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

⚠️ The file 'Cargo.toml or constant.rs' has been modified in this PR. Please review the changes carefully.

@fda-odoo fda-odoo requested a review from mmahrouss October 8, 2025 16:04
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

⚠️ The file 'Cargo.toml or constant.rs' has been modified in this PR. Please review the changes carefully.

@fda-odoo fda-odoo marked this pull request as ready for review October 8, 2025 16:04

[features]
default = []
default = ["debug_yarn"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you push this intentionally?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

Comment on lines 9 to 14
pub const DEBUG_MEMORY: bool = true;
pub const DEBUG_THREADS: bool = false;
pub const DEBUG_STEPS: bool = false;
pub const DEBUG_STEPS_ONLY_INTERNAL: bool = true;
pub const DEBUG_REBUILD_NOW: bool = false;
pub const DEBUG_REBUILD_NOW: bool = true;
pub const DEBUG_BORROW_GUARDS: bool = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with those? do you want to have them enabled on Alpha? and we'll revert them on release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 😅

(Some(Identifier::new(from_stmt_inner.clone(), TextRange::default())), import.clone())
}
},
None => (None, S!("")),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be import.clone() ?

Like that import odo| will try to list everything because it is starting from empty string?

Suggested change
None => (None, S!("")),
None => (None, import.clone()),

@fda-odoo
Copy link
Collaborator Author

closed for #443

@fda-odoo fda-odoo closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants