-
Notifications
You must be signed in to change notification settings - Fork 22
[IMP] Autocompletion on import statements #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
df45d29 to
94f2843
Compare
|
|
1 similar comment
|
|
|
|
a6f458f to
b972b4f
Compare
|
|
server/Cargo.toml
Outdated
|
|
||
| [features] | ||
| default = [] | ||
| default = ["debug_yarn"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you push this intentionally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
server/src/constants.rs
Outdated
| pub const DEBUG_MEMORY: bool = true; | ||
| pub const DEBUG_THREADS: bool = false; | ||
| pub const DEBUG_STEPS: bool = false; | ||
| pub const DEBUG_STEPS_ONLY_INTERNAL: bool = true; | ||
| pub const DEBUG_REBUILD_NOW: bool = false; | ||
| pub const DEBUG_REBUILD_NOW: bool = true; | ||
| pub const DEBUG_BORROW_GUARDS: bool = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with those? do you want to have them enabled on Alpha? and we'll revert them on release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 😅
server/src/core/import_resolver.rs
Outdated
| (Some(Identifier::new(from_stmt_inner.clone(), TextRange::default())), import.clone()) | ||
| } | ||
| }, | ||
| None => (None, S!("")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be import.clone() ?
Like that import odo| will try to list everything because it is starting from empty string?
| None => (None, S!("")), | |
| None => (None, import.clone()), |
b972b4f to
d8ea334
Compare
d8ea334 to
72a45cb
Compare
72a45cb to
b858abc
Compare
|
closed for #443 |
No description provided.